From: Kurt Kanzenbach <kurt@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/2] ptp: Add generic header parsing function
Date: Sat, 25 Jul 2020 09:04:36 +0200 [thread overview]
Message-ID: <871rl0nkhn.fsf@kurt> (raw)
In-Reply-To: <20200724160335.GA30531@hoboy>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Fri Jul 24 2020, Richard Cochran wrote:
> On Fri, Jul 24, 2020 at 08:25:59AM +0200, Kurt Kanzenbach wrote:
>> |static inline u8 ptp_get_msgtype(const struct ptp_header *hdr, unsigned int type)
>> |{
>> | u8 msg;
>> |
>> | if (unlikely(type & PTP_CLASS_V1))
>> | /* msg type is located @ offset 20 for ptp v1 */
>> | msg = hdr->source_port_identity.clock_identity.id[0];
>> | else
>> | msg = hdr->tsmt & 0x0f;
>> |
>> | return msg;
>> |}
>>
>> What do you think about it?
>
> Looks good.
OK, I'll add it.
>
> I can also test the dp83640. Maybe you could test the cpts on a bbb?
Most likely, yes.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-25 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:49 [PATCH v1 0/2] ptp: Add generic header parsing function Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 1/2] ptp: Add generic ptp v2 " Kurt Kanzenbach
2020-07-23 10:54 ` Kurt Kanzenbach
2020-07-23 7:49 ` [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp " Kurt Kanzenbach
2020-07-23 17:11 ` Richard Cochran
2020-07-24 6:07 ` Kurt Kanzenbach
2020-07-23 17:08 ` [PATCH v1 0/2] ptp: Add generic " Richard Cochran
2020-07-24 6:25 ` Kurt Kanzenbach
2020-07-24 16:03 ` Richard Cochran
2020-07-25 7:04 ` Kurt Kanzenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rl0nkhn.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).