From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7DBC43331 for ; Wed, 1 Apr 2020 05:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B090F2072E for ; Wed, 1 Apr 2020 05:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731772AbgDAFSD (ORCPT ); Wed, 1 Apr 2020 01:18:03 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:52458 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731735AbgDAFSD (ORCPT ); Wed, 1 Apr 2020 01:18:03 -0400 Received: from tarshish (unknown [10.0.8.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id F08A34409E2; Wed, 1 Apr 2020 08:18:01 +0300 (IDT) References: <16e4a15e359012fc485d22c7e413a129029fbd0f.1585676858.git.baruch@tkos.co.il> <8f4ecf61-ed50-9de6-f20a-0ade5f3dcb9a@gmail.com> User-agent: mu4e 1.2.0; emacs 26.1 From: Baruch Siach To: Florian Fainelli Cc: Heiner Kallweit , Russell King , netdev@vger.kernel.org, Shmuel Hazan , Andrew Lunn Subject: Re: [PATCH] net: phy: marvell10g: add firmware load support In-reply-to: Date: Wed, 01 Apr 2020 08:18:01 +0300 Message-ID: <871rp7dbsm.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Florian, On Tue, Mar 31 2020, Florian Fainelli wrote: > On 3/31/2020 11:16 AM, Heiner Kallweit wrote: >> On 31.03.2020 19:47, Baruch Siach wrote: >>> When Marvell 88X3310 and 88E2110 hardware configuration SPI_CONFIG strap >>> bit is pulled up, the host must load firmware to the PHY after reset. >>> Add support for loading firmware. >>> >>> Firmware files are available from Marvell under NDA. >> >> Loading firmware files that are available under NDA only in GPL-licensed >> code may be problematic. I'd expect firmware files to be available in >> linux-firmware at least. >> I'd be interested in how the other phylib maintainers see this. > > I second that, having the firmware available in linux-firmware is > necessary for this code to be accepted. That's your decision to make. In any case I'll post an updated version of this patch with fixes for reference to anyone who needs this functionality to make these PHYs work. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -