* Re: linux-next: build warnings after merge of the wireless-drivers-next tree [not found] <20181130120555.1d35eb6b@canb.auug.org.au> @ 2018-12-19 2:47 ` Stephen Rothwell 2018-12-19 7:51 ` Kalle Valo 0 siblings, 1 reply; 5+ messages in thread From: Stephen Rothwell @ 2018-12-19 2:47 UTC (permalink / raw) To: Kalle Valo, Wireless Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sara Sharon, Luca Coelho, Kees Cook, Gustavo A. R. Silva, David Miller, Networking [-- Attachment #1: Type: text/plain, Size: 1475 bytes --] Hi all, On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) produced these warnings: > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware': > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (iwlwifi_mod_params.enable_ini) > ^ > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here > default: > ^~~~~~~ > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv': > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=] > iwl_fw_dbg_copy_tlv(trans, tlv, true); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here > default: > ^~~~~~~ > > Introduced by commit > > f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") > > These are noted because I use -Wimplict-fallthrough > > The warnings can be suppressed by adding a comment like > /* fall through */ > at the appropriate place to indicate that the fallthough is intended. I am still seeing these warnings (but in the net-next tree now) and I do not see a fix patch in the wireless-drivers-next tree. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings after merge of the wireless-drivers-next tree 2018-12-19 2:47 ` linux-next: build warnings after merge of the wireless-drivers-next tree Stephen Rothwell @ 2018-12-19 7:51 ` Kalle Valo 2018-12-19 8:31 ` Grumbach, Emmanuel 0 siblings, 1 reply; 5+ messages in thread From: Kalle Valo @ 2018-12-19 7:51 UTC (permalink / raw) To: Stephen Rothwell Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List, Sara Sharon, Luca Coelho, Kees Cook, Gustavo A. R. Silva, David Miller, Networking, Emmanuel Grumbach Stephen Rothwell <sfr@canb.auug.org.au> writes: > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> After merging the wireless-drivers-next tree, today's linux-next build >> (x86_64 allmodconfig) produced these warnings: >> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware': >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (iwlwifi_mod_params.enable_ini) >> ^ >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here >> default: >> ^~~~~~~ >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv': >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=] >> iwl_fw_dbg_copy_tlv(trans, tlv, true); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here >> default: >> ^~~~~~~ >> >> Introduced by commit >> >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") >> >> These are noted because I use -Wimplict-fallthrough >> >> The warnings can be suppressed by adding a comment like >> /* fall through */ >> at the appropriate place to indicate that the fallthough is intended. > > I am still seeing these warnings (but in the net-next tree now) and I > do not see a fix patch in the wireless-drivers-next tree. Luca did submit a patch[1] for cfg80211 to fix those but I don't see any patches for iwlwifi (even in the one pending pull request he sent), not sure what happened. I know that Luca is already on holidays but adding Emmanuel, maybe he can help here? [1] https://patchwork.kernel.org/patch/10732065/ -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: linux-next: build warnings after merge of the wireless-drivers-next tree 2018-12-19 7:51 ` Kalle Valo @ 2018-12-19 8:31 ` Grumbach, Emmanuel [not found] ` <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C-cNwSTNrqBuVP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org> 2018-12-19 12:40 ` Kalle Valo 0 siblings, 2 replies; 5+ messages in thread From: Grumbach, Emmanuel @ 2018-12-19 8:31 UTC (permalink / raw) To: Kalle Valo, Stephen Rothwell Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List, Sharon, Sara, Coelho, Luciano, Kees Cook, Gustavo A. R. Silva, David Miller, Networking > > Stephen Rothwell <sfr@canb.auug.org.au> writes: > > > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell > <sfr@canb.auug.org.au> wrote: > >> > >> After merging the wireless-drivers-next tree, today's linux-next > >> build > >> (x86_64 allmodconfig) produced these warnings: > >> > >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function > 'iwl_parse_tlv_firmware': > >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this > statement may fall through [-Wimplicit-fallthrough=] > >> if (iwlwifi_mod_params.enable_ini) > >> ^ > >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here > >> default: > >> ^~~~~~~ > >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function > 'iwl_parse_fw_dbg_tlv': > >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this > statement may fall through [-Wimplicit-fallthrough=] > >> iwl_fw_dbg_copy_tlv(trans, tlv, true); > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here > >> default: > >> ^~~~~~~ > >> > >> Introduced by commit > >> > >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") > >> > >> These are noted because I use -Wimplict-fallthrough > >> > >> The warnings can be suppressed by adding a comment like > >> /* fall through */ > >> at the appropriate place to indicate that the fallthough is intended. > > > > I am still seeing these warnings (but in the net-next tree now) and I > > do not see a fix patch in the wireless-drivers-next tree. > > Luca did submit a patch[1] for cfg80211 to fix those but I don't see any > patches for iwlwifi (even in the one pending pull request he sent), not sure > what happened. I know that Luca is already on holidays but adding > Emmanuel, maybe he can help here? > Just sent a patch. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C-cNwSTNrqBuVP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: linux-next: build warnings after merge of the wireless-drivers-next tree [not found] ` <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C-cNwSTNrqBuVP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2018-12-19 10:27 ` Luca Coelho 0 siblings, 0 replies; 5+ messages in thread From: Luca Coelho @ 2018-12-19 10:27 UTC (permalink / raw) To: Grumbach, Emmanuel, Kalle Valo, Stephen Rothwell Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List, Sharon, Sara, Kees Cook, Gustavo A. R. Silva, David Miller, Networking On Wed, 2018-12-19 at 08:31 +0000, Grumbach, Emmanuel wrote: > > Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> writes: > > > > > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell > > <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote: > > > > After merging the wireless-drivers-next tree, today's linux-next > > > > build > > > > (x86_64 allmodconfig) produced these warnings: > > > > > > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function > > 'iwl_parse_tlv_firmware': > > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this > > statement may fall through [-Wimplicit-fallthrough=] > > > > if (iwlwifi_mod_params.enable_ini) > > > > ^ > > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here > > > > default: > > > > ^~~~~~~ > > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function > > 'iwl_parse_fw_dbg_tlv': > > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this > > statement may fall through [-Wimplicit-fallthrough=] > > > > iwl_fw_dbg_copy_tlv(trans, tlv, true); > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here > > > > default: > > > > ^~~~~~~ > > > > > > > > Introduced by commit > > > > > > > > f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") > > > > > > > > These are noted because I use -Wimplict-fallthrough > > > > > > > > The warnings can be suppressed by adding a comment like > > > > /* fall through */ > > > > at the appropriate place to indicate that the fallthough is intended. > > > > > > I am still seeing these warnings (but in the net-next tree now) and I > > > do not see a fix patch in the wireless-drivers-next tree. > > > > Luca did submit a patch[1] for cfg80211 to fix those but I don't see any > > patches for iwlwifi (even in the one pending pull request he sent), not sure > > what happened. I know that Luca is already on holidays but adding > > Emmanuel, maybe he can help here? > > > > Just sent a patch. Those patches were still queued for upstreaming and I didn't think they were that urgent, so I didn't pick them. -- Luca. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings after merge of the wireless-drivers-next tree 2018-12-19 8:31 ` Grumbach, Emmanuel [not found] ` <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C-cNwSTNrqBuVP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2018-12-19 12:40 ` Kalle Valo 1 sibling, 0 replies; 5+ messages in thread From: Kalle Valo @ 2018-12-19 12:40 UTC (permalink / raw) To: Grumbach, Emmanuel Cc: Stephen Rothwell, Wireless, Linux Next Mailing List, Linux Kernel Mailing List, Sharon, Sara, Coelho, Luciano, Kees Cook, Gustavo A. R. Silva, David Miller, Networking "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> writes: >> >> Stephen Rothwell <sfr@canb.auug.org.au> writes: >> >> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell >> <sfr@canb.auug.org.au> wrote: >> >> >> >> After merging the wireless-drivers-next tree, today's linux-next >> >> build >> >> (x86_64 allmodconfig) produced these warnings: >> >> >> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function >> 'iwl_parse_tlv_firmware': >> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this >> statement may fall through [-Wimplicit-fallthrough=] >> >> if (iwlwifi_mod_params.enable_ini) >> >> ^ >> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here >> >> default: >> >> ^~~~~~~ >> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function >> 'iwl_parse_fw_dbg_tlv': >> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this >> statement may fall through [-Wimplicit-fallthrough=] >> >> iwl_fw_dbg_copy_tlv(trans, tlv, true); >> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here >> >> default: >> >> ^~~~~~~ >> >> >> >> Introduced by commit >> >> >> >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") >> >> >> >> These are noted because I use -Wimplict-fallthrough >> >> >> >> The warnings can be suppressed by adding a comment like >> >> /* fall through */ >> >> at the appropriate place to indicate that the fallthough is intended. >> > >> > I am still seeing these warnings (but in the net-next tree now) and I >> > do not see a fix patch in the wireless-drivers-next tree. >> >> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any >> patches for iwlwifi (even in the one pending pull request he sent), not sure >> what happened. I know that Luca is already on holidays but adding >> Emmanuel, maybe he can help here? >> > > Just sent a patch. I see it thanks: https://patchwork.kernel.org/patch/10736967/ I'll try to get it to tomorrow's linux-next build. -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-19 12:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181130120555.1d35eb6b@canb.auug.org.au>
2018-12-19 2:47 ` linux-next: build warnings after merge of the wireless-drivers-next tree Stephen Rothwell
2018-12-19 7:51 ` Kalle Valo
2018-12-19 8:31 ` Grumbach, Emmanuel
[not found] ` <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C-cNwSTNrqBuVP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-12-19 10:27 ` Luca Coelho
2018-12-19 12:40 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).