From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] net: cleanup miss usage of seq_release_private
Date: Thu, 08 Jul 2004 04:26:14 +0900 [thread overview]
Message-ID: <871xjnmxex.fsf@devron.myhome.or.jp> (raw)
These doesn't allocate memory and doesn't use seq->private. However
kfree() ignores NULL, so these are not the problem.
This patch just cleans these up.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
net/ipv4/route.c | 2 +-
net/irda/discovery.c | 2 +-
net/irda/ircomm/ircomm_core.c | 2 +-
net/irda/iriap.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff -puN net/ipv4/route.c~net-seq_release-cleanup net/ipv4/route.c
--- linux-2.6.7/net/ipv4/route.c~net-seq_release-cleanup 2004-07-08 00:01:20.000000000 +0900
+++ linux-2.6.7-hirofumi/net/ipv4/route.c 2004-07-08 00:01:20.000000000 +0900
@@ -432,7 +432,7 @@ static struct file_operations rt_cpu_seq
.open = rt_cpu_seq_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release,
};
#endif /* CONFIG_PROC_FS */
diff -puN net/irda/discovery.c~net-seq_release-cleanup net/irda/discovery.c
--- linux-2.6.7/net/irda/discovery.c~net-seq_release-cleanup 2004-07-08 00:01:20.000000000 +0900
+++ linux-2.6.7-hirofumi/net/irda/discovery.c 2004-07-08 00:01:20.000000000 +0900
@@ -449,6 +449,6 @@ struct file_operations discovery_seq_fop
.open = discovery_seq_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release,
};
#endif
diff -puN net/irda/iriap.c~net-seq_release-cleanup net/irda/iriap.c
--- linux-2.6.7/net/irda/iriap.c~net-seq_release-cleanup 2004-07-08 00:01:20.000000000 +0900
+++ linux-2.6.7-hirofumi/net/irda/iriap.c 2004-07-08 00:01:20.000000000 +0900
@@ -1093,7 +1093,7 @@ struct file_operations irias_seq_fops =
.open = irias_seq_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release,
};
#endif /* PROC_FS */
diff -puN net/irda/ircomm/ircomm_core.c~net-seq_release-cleanup net/irda/ircomm/ircomm_core.c
--- linux-2.6.7/net/irda/ircomm/ircomm_core.c~net-seq_release-cleanup 2004-07-08 00:01:20.000000000 +0900
+++ linux-2.6.7-hirofumi/net/irda/ircomm/ircomm_core.c 2004-07-08 00:01:20.000000000 +0900
@@ -62,7 +62,7 @@ static struct file_operations ircomm_pro
.open = ircomm_seq_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release,
};
#endif /* CONFIG_PROC_FS */
_
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next reply other threads:[~2004-07-07 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-07 19:26 OGAWA Hirofumi [this message]
2004-07-07 21:10 ` [PATCH] net: cleanup miss usage of seq_release_private David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871xjnmxex.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).