From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5FD638A9D4 for ; Tue, 13 Jan 2026 12:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768308740; cv=none; b=Wr140hh6h+ShKHsvByw7oFlq2d6mcyMRSxIZ+hJrE5ZQX62XihSZnOxbnS7zYTZK5dZgsd2EO39s5OaxdmInBpkgOLW1v1nhzTYYLbQakzrJ8JX/CoH5YWPmkAY6Ol9NESbwvNK1xgklpVY9/bMXRIT+SlOVpT4Wvv/83Pknd+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768308740; c=relaxed/simple; bh=M3cd1ChoyL/JPoUh1TebMNfZNb0CMOQ+wKlup/AKWzI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=d8+xXMldUYZRoKFopKzLXkTZp/aic/zuznCTgy3i0faVTHhcT3/uFHFZsQ06DIedZERUF0G17w+MGkURSsKyzF5Br5FC3sYm6LbtFv2ueZrWQSf69tEVgnD+UsdnjBRn6Y/OrAEbSEzMgm3ThIXTqszyQTRAY8ZF2RcdXNj33rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=UJCF6D6L; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="UJCF6D6L" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b87113bd83bso399314366b.1 for ; Tue, 13 Jan 2026 04:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1768308737; x=1768913537; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uEb4fpri3npogF5JFpOtWuoL+P7ayMQsw+8rwNvJPCI=; b=UJCF6D6LC6b8pKI37H8H6uwCtxnY+bmQP6DMaYddWTbJSgZpLHhTbQM358bn5S5xS4 qIgDKfHKxt5ShNajmTZNOhEI6lk6dyOQlTDrirBc/A8rsebRG2RSVrBTNrtAR/k50ezj AB+B9ZIrmnZaUo5Vu04Dm+3jgdsJRSOCRFDr4H5yrjPn7XTa+kAMk/t9Y5NDkRDalhwr e4+ATGp6OfT6Aq2vke/Sp/Vc/a4sn0E/FUdSLjGXS/ugfe72mM9LiZFsoQwavbbTYCpf GsUqSfYGJKTk+3x7IhEJJyA7wHrHwyORGItLVyEzl8TDBE/0z6oGOgxGBlnYiq7omenn i3tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768308737; x=1768913537; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uEb4fpri3npogF5JFpOtWuoL+P7ayMQsw+8rwNvJPCI=; b=D5aGvWuU4dPVTSgcDo/chpM9vRL3HkA8942csZGTJm34JeW5ZAvSIrlXHukSMSMkbE UKYJRP36LVIO/E82VNUGaEhKHioq6VMjfK2L+UwHCjauNt3lBFCXMc5FBPWHcYoau1Di T9c4uozHpNb6gHYGtQNmGbKVtdQeGJfng1vHjaW6SDTpOSwskTNJ9Gr+ynfvNVe/yBRi rgkdIqTq6QdRQUrVPNmpyq914gJ73wruV5NLevWbl9/YR0gwQFEQGLKlMlI6ZoGfxaZf NdwUlEZj1Tr//BuNtrMbwNRVeyLvm2SaYSWel9btYjTBPsxvWs+akOTSM2iAX6J60BG0 ucdQ== X-Gm-Message-State: AOJu0YzZwOOnJdo0ntGGbOINa9O98rR1go9cZHZ1pqeWCA6OFWSfv3Xq gepx05+bx93LywdUgRzGMw9Ztut14/6ThzEGSzWEdsoJ4Z7TisU81SIHxqhzhTYM2oY= X-Gm-Gg: AY/fxX7IG6cFS4UltoAGaIvZ5i4uSpkbBQjpVDUxWWRoP0HJ6heQ6R2k/e6nw3rJZcU O4udSSsRAXjAoOYI9CexbYeH7SKwuWWRNu5I8Y+85JkvM6rZQMUqTxD/ic4io7pJRXH9fuaHttc gx7rQT+wWNhRDRw/5deAXNMinveNfFna46DReWm6wu05fYC2rOZ9rWFypBQIVoqIt77hEgpCcRr 2z3GHk2OZHW182yvei5aiF977A2zUVrjGqxy5tIJIQHAWVBpPlDXpT+RqZb6tL4bI1fw/+mVDmY 94V/XOB/Yxumqk7UOzPhifidaMutqzkNaZ3ySEBC1KYePfq80meVJZYYou8mN1sat1l7A4zXyO3 XABJtIyGlOlzSKwgX0DbxVCiSiTV0vvSTBi7sh0jbOsyMHFKysqbNBkrVXUljxsuaZxlKtl9f3T lX5rPmsJBVZM3j X-Google-Smtp-Source: AGHT+IFX81GRz/hwINL72rPQLm6j5tregnFNpNUvMTj08WVBOxYe/hO3B2KEOTqbE2tiVZ7xDeaggw== X-Received: by 2002:a17:907:7293:b0:b87:2fcd:1955 with SMTP id a640c23a62f3a-b872fcd1bf1mr388012666b.50.1768308737057; Tue, 13 Jan 2026 04:52:17 -0800 (PST) Received: from cloudflare.com ([2a09:bac5:5063:2dc::49:1cb]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8706c2604bsm780426066b.16.2026.01.13.04.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 04:52:16 -0800 (PST) From: Jakub Sitnicki To: Tariq Toukan Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Michael Chan , Pavan Chebbi , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , intel-wired-lan@lists.osuosl.org, bpf@vger.kernel.org, kernel-team@cloudflare.com Subject: Re: [PATCH net-next 07/10] mlx5e: Call skb_metadata_set when skb->data points past metadata In-Reply-To: <4261e437-84b2-4d0d-af52-c5ee7fcf07cb@gmail.com> (Tariq Toukan's message of "Tue, 13 Jan 2026 08:08:48 +0200") References: <20260110-skb-meta-fixup-skb_metadata_set-calls-v1-0-1047878ed1b0@cloudflare.com> <20260110-skb-meta-fixup-skb_metadata_set-calls-v1-7-1047878ed1b0@cloudflare.com> <4261e437-84b2-4d0d-af52-c5ee7fcf07cb@gmail.com> Date: Tue, 13 Jan 2026 13:52:15 +0100 Message-ID: <873449wu80.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jan 13, 2026 at 08:08 AM +02, Tariq Toukan wrote: > On 10/01/2026 23:05, Jakub Sitnicki wrote: >> Prepare to copy the XDP metadata into an skb extension in skb_metadata_set. >> Adjust the driver to pull from skb->data before calling skb_metadata_set. >> Signed-off-by: Jakub Sitnicki >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c >> b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c >> index 2b05536d564a..20c983c3ce62 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c >> @@ -237,8 +237,8 @@ static struct sk_buff *mlx5e_xsk_construct_skb(struct mlx5e_rq *rq, struct xdp_b >> skb_put_data(skb, xdp->data_meta, totallen); >> if (metalen) { >> - skb_metadata_set(skb, metalen); >> __skb_pull(skb, metalen); >> + skb_metadata_set(skb, metalen); >> } >> return skb; >> > > Patch itself is simple.. > > I share my concerns about the perf impact of the series idea. > Do you have some working PoC? Please share some perf numbers.. Sorry, nothing to show yet. I've shared more context in my reply to Jakub [1]. The series itself is an interface cleanup, whether we end up needing it for the metadata effort or not. Hence I wanted to salvage it from [2]. [1] https://lore.kernel.org/all/87bjixwv41.fsf@cloudflare.com/ [2] https://lore.kernel.org/r/20260107-skb-meta-safeproof-netdevs-rx-only-v3-0-0d461c5e4764@cloudflare.com