[RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

ieee802154_mlme_tx_one() was added in 2022 by
commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
commands") but has remained unused.

Remove it.

Note, there's still a ieee802154_mlme_tx_one_locked()
variant that is used.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 net/mac802154/ieee802154_i.h |  3 ---
 net/mac802154/tx.c           | 13 -------------
 2 files changed, 16 deletions(-)

diff --git a/net/mac802154/ieee802154_i.h b/net/mac802154/ieee802154_i.h
index 08dd521a51a5..8f2bff268392 100644
--- a/net/mac802154/ieee802154_i.h
+++ b/net/mac802154/ieee802154_i.h
@@ -194,9 +194,6 @@ int ieee802154_mlme_tx_locked(struct ieee802154_local *local,
 			      struct ieee802154_sub_if_data *sdata,
 			      struct sk_buff *skb);
 void ieee802154_mlme_op_post(struct ieee802154_local *local);
-int ieee802154_mlme_tx_one(struct ieee802154_local *local,
-			   struct ieee802154_sub_if_data *sdata,
-			   struct sk_buff *skb);
 int ieee802154_mlme_tx_one_locked(struct ieee802154_local *local,
 				  struct ieee802154_sub_if_data *sdata,
 				  struct sk_buff *skb);
diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
index 337d6faf0d2a..4d13f18f6f2c 100644
--- a/net/mac802154/tx.c
+++ b/net/mac802154/tx.c
@@ -178,19 +178,6 @@ void ieee802154_mlme_op_post(struct ieee802154_local *local)
 	ieee802154_release_queue(local);
 }
 
-int ieee802154_mlme_tx_one(struct ieee802154_local *local,
-			   struct ieee802154_sub_if_data *sdata,
-			   struct sk_buff *skb)
-{
-	int ret;
-
-	ieee802154_mlme_op_pre(local);
-	ret = ieee802154_mlme_tx(local, sdata, skb);
-	ieee802154_mlme_op_post(local);
-
-	return ret;
-}
-
 int ieee802154_mlme_tx_one_locked(struct ieee802154_local *local,
 				  struct ieee802154_sub_if_data *sdata,
 				  struct sk_buff *skb)
-- 
2.47.1

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[Miquel Raynal]

Hello,

On 25/12/2024 at 01:24:23 GMT, linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> ieee802154_mlme_tx_one() was added in 2022 by
> commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
> commands") but has remained unused.
>
> Remove it.
>
> Note, there's still a ieee802154_mlme_tx_one_locked()
> variant that is used.
>

I don't remember what this is for. I didn't find any use of it in my desperately
downstream branches, so it must be a leftover.

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[Stefan Schmidt]

Hello linux@treblig.org.

On Wed, 25 Dec 2024 01:24:23 +0000, linux@treblig.org wrote:
> ieee802154_mlme_tx_one() was added in 2022 by
> commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
> commands") but has remained unused.
> 
> Remove it.
> 
> Note, there's still a ieee802154_mlme_tx_one_locked()
> variant that is used.
> 
> [...]

Applied to wpan/wpan-next.git, thanks!

[1/1] net: mac802154: Remove unused ieee802154_mlme_tx_one
      https://git.kernel.org/wpan/wpan-next/c/bddfe23be8f8

regards,
Stefan Schmidt

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[Dr. David Alan Gilbert]

* Stefan Schmidt (stefan@datenfreihafen.org) wrote:
> Hello linux@treblig.org.
> 
> On Wed, 25 Dec 2024 01:24:23 +0000, linux@treblig.org wrote:
> > ieee802154_mlme_tx_one() was added in 2022 by
> > commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
> > commands") but has remained unused.
> > 
> > Remove it.
> > 
> > Note, there's still a ieee802154_mlme_tx_one_locked()
> > variant that is used.
> > 
> > [...]
> 
> Applied to wpan/wpan-next.git, thanks!

Thanks! I'd been thinking I had to wait for net-next to reopen.

Dave

> [1/1] net: mac802154: Remove unused ieee802154_mlme_tx_one
>       https://git.kernel.org/wpan/wpan-next/c/bddfe23be8f8
> 
> regards,
> Stefan Schmidt
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[Stefan Schmidt]

Hello Dave,

On 30.12.24 18:44, Dr. David Alan Gilbert wrote:
> * Stefan Schmidt (stefan@datenfreihafen.org) wrote:
>> Hello linux@treblig.org.
>>
>> On Wed, 25 Dec 2024 01:24:23 +0000, linux@treblig.org wrote:
>>> ieee802154_mlme_tx_one() was added in 2022 by
>>> commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
>>> commands") but has remained unused.
>>>
>>> Remove it.
>>>
>>> Note, there's still a ieee802154_mlme_tx_one_locked()
>>> variant that is used.
>>>
>>> [...]
>>
>> Applied to wpan/wpan-next.git, thanks!
> 
> Thanks! I'd been thinking I had to wait for net-next to reopen.

It's in my wpan-next tree and I will send a pull request to net-next 
when it opens up again.

regards
Stefan Schmidt

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

[Dr. David Alan Gilbert]

* Stefan Schmidt (stefan@datenfreihafen.org) wrote:
> Hello Dave,
> 
> On 30.12.24 18:44, Dr. David Alan Gilbert wrote:
> > * Stefan Schmidt (stefan@datenfreihafen.org) wrote:
> > > Hello linux@treblig.org.
> > > 
> > > On Wed, 25 Dec 2024 01:24:23 +0000, linux@treblig.org wrote:
> > > > ieee802154_mlme_tx_one() was added in 2022 by
> > > > commit ddd9ee7cda12 ("net: mac802154: Introduce a synchronous API for MLME
> > > > commands") but has remained unused.
> > > > 
> > > > Remove it.
> > > > 
> > > > Note, there's still a ieee802154_mlme_tx_one_locked()
> > > > variant that is used.
> > > > 
> > > > [...]
> > > 
> > > Applied to wpan/wpan-next.git, thanks!
> > 
> > Thanks! I'd been thinking I had to wait for net-next to reopen.
> 
> It's in my wpan-next tree and I will send a pull request to net-next when it
> opens up again.

Thanks, I see it in linux-next.

Dave

> regards
> Stefan Schmidt
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/