From: Petr Machata <petrm@nvidia.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Michal Kubecek <mkubecek@suse.cz>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Rui Sousa <rui.sousa@nxp.com>,
Ferenc Fejes <ferenc.fejes@ericsson.com>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Harini Katakam <harini.katakam@amd.com>,
<UNGLinuxDriver@microchip.com>, "Petr Machata" <petrm@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [RFC PATCH net-next] selftests: forwarding: add a test for MAC Merge layer
Date: Mon, 13 Feb 2023 11:51:37 +0100 [thread overview]
Message-ID: <873579ddv0.fsf@nvidia.com> (raw)
In-Reply-To: <20230210221243.228932-1-vladimir.oltean@nxp.com>
Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> +# Borrowed from mlxsw/qos_lib.sh, message adapted.
> +bail_on_lldpad()
> +{
> + if systemctl is-active --quiet lldpad; then
> + cat >/dev/stderr <<-EOF
> + WARNING: lldpad is running
> +
> + lldpad will likely autoconfigure the MAC Merge layer,
> + while this test will configure it manually. One of them
> + is arbitrarily going to overwrite the other. That will
> + cause spurious failures (or, unlikely, passes) of this
> + test.
> + EOF
> + exit 1
> + fi
> +}
This would be good to have unified. Can you make the function reusable,
with a generic or parametrized message? I should be able to carve a bit
of time later to move it to lib.sh, migrate the mlxsw selftests, and
drop the qos_lib.sh copy.
next prev parent reply other threads:[~2023-02-13 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 22:12 [RFC PATCH net-next] selftests: forwarding: add a test for MAC Merge layer Vladimir Oltean
2023-02-13 10:51 ` Petr Machata [this message]
2023-02-13 11:39 ` Vladimir Oltean
2023-02-14 11:53 ` Petr Machata
2023-03-15 15:52 ` Vladimir Oltean
2023-03-16 11:10 ` Petr Machata
2023-03-16 13:43 ` Petr Machata
2023-03-17 15:35 ` Petr Machata
2023-03-17 15:45 ` Vladimir Oltean
2023-03-20 10:20 ` Petr Machata
2023-03-20 13:49 ` Petr Machata
2023-02-13 11:42 ` Kurt Kanzenbach
2023-02-13 12:02 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873579ddv0.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aconole@redhat.com \
--cc=ferenc.fejes@ericsson.com \
--cc=harini.katakam@amd.com \
--cc=idosch@nvidia.com \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pranavi.somisetty@amd.com \
--cc=rui.sousa@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).