From: Kalle Valo <kvalo@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Lizhe <sensor1010@163.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
johannes.berg@intel.com, alexander@wetzel-home.de,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kzalloc replaces kmalloc
Date: Mon, 16 Jan 2023 08:32:37 +0200 [thread overview]
Message-ID: <87358bat16.fsf@kernel.org> (raw)
In-Reply-To: <CANn89iKDXQ_nvnXBp5Q99P67AW-jFTNkpEmYdESDWitf0Nt4vw@mail.gmail.com> (Eric Dumazet's message of "Fri, 13 Jan 2023 14:44:58 +0100")
Eric Dumazet <edumazet@google.com> writes:
> On Fri, Jan 13, 2023 at 2:35 PM Lizhe <sensor1010@163.com> wrote:
>>
>> use devm_kzalloc replaces kamlloc
>>
>> Signed-off-by: Lizhe <sensor1010@163.com>
>> ---
>> drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
>> index 009bca34ece3..ebd8ef525557 100644
>> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
>> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
>> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>>
>> udev = usb_get_dev(interface_to_usbdev(interface));
>>
>> - fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
>> + fwv = devm_kzalloc(sizeof(*fwv), GFP_KERNEL);
>
> Have you compiled this patch ?
Clearly not:
https://lore.kernel.org/linux-wireless/202301140533.jMlST9Ur-lkp@intel.com/
Lizhe, do not EVER submit untested patches. In some simple patches doing
just a compilation test might suffice, but please mention the patch is
only compile tested clearly in the commit log. But not even doing a
compilation test is a big no.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-01-16 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 13:35 [PATCH v1] wireless/at76c50x-usb.c : Use devm_kzalloc replaces kmalloc Lizhe
2023-01-13 13:44 ` Eric Dumazet
2023-01-16 6:32 ` Kalle Valo [this message]
2023-01-13 21:15 ` kernel test robot
2023-01-14 19:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87358bat16.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alexander@wetzel-home.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sensor1010@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).