* [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter()
@ 2022-09-15 8:58 Hangyu Hua
2022-09-15 14:17 ` Vlad Buslov
2022-09-20 15:50 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Hangyu Hua @ 2022-09-15 8:58 UTC (permalink / raw)
To: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni, vladbu
Cc: netdev, linux-kernel, Hangyu Hua
tfilter_put need to be called to put the refount got by tp->ops->get to
avoid possible refcount leak when chain->tmplt_ops == NULL or
chain->tmplt_ops != tp->ops.
Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
net/sched/cls_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 790d6809be81..51d175f3fbcb 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
}
if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {
+ tfilter_put(tp, fh);
NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");
err = -EINVAL;
goto errout;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter()
2022-09-15 8:58 [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter() Hangyu Hua
@ 2022-09-15 14:17 ` Vlad Buslov
2022-09-20 15:50 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Vlad Buslov @ 2022-09-15 14:17 UTC (permalink / raw)
To: Hangyu Hua
Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni, vladbu,
netdev, linux-kernel
On Thu 15 Sep 2022 at 16:58, Hangyu Hua <hbh25y@gmail.com> wrote:
> tfilter_put need to be called to put the refount got by tp->ops->get to
> avoid possible refcount leak when chain->tmplt_ops == NULL or
> chain->tmplt_ops != tp->ops.
>
> Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
Thanks for fixing this!
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
> net/sched/cls_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 790d6809be81..51d175f3fbcb 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
> }
>
> if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {
> + tfilter_put(tp, fh);
> NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");
> err = -EINVAL;
> goto errout;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter()
2022-09-15 8:58 [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter() Hangyu Hua
2022-09-15 14:17 ` Vlad Buslov
@ 2022-09-20 15:50 ` Jakub Kicinski
2022-09-21 9:08 ` Hangyu Hua
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-09-20 15:50 UTC (permalink / raw)
To: Hangyu Hua
Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, pabeni, vladbu,
netdev, linux-kernel
On Thu, 15 Sep 2022 16:58:04 +0800 Hangyu Hua wrote:
> tfilter_put need to be called to put the refount got by tp->ops->get to
s/refount/refcount/
> avoid possible refcount leak when chain->tmplt_ops == NULL or
> chain->tmplt_ops != tp->ops.
This should say:
when cain->tmplt_ops != NULL and ...
otherwise the commit message does not match the code.
> Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> net/sched/cls_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 790d6809be81..51d175f3fbcb 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
> }
>
> if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {
> + tfilter_put(tp, fh);
> NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");
> err = -EINVAL;
> goto errout;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter()
2022-09-20 15:50 ` Jakub Kicinski
@ 2022-09-21 9:08 ` Hangyu Hua
0 siblings, 0 replies; 4+ messages in thread
From: Hangyu Hua @ 2022-09-21 9:08 UTC (permalink / raw)
To: Jakub Kicinski
Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, pabeni, vladbu,
netdev, linux-kernel
On 20/9/2022 23:50, Jakub Kicinski wrote:
> On Thu, 15 Sep 2022 16:58:04 +0800 Hangyu Hua wrote:
>> tfilter_put need to be called to put the refount got by tp->ops->get to
>
> s/refount/refcount/
>
>> avoid possible refcount leak when chain->tmplt_ops == NULL or
>> chain->tmplt_ops != tp->ops.
>
> This should say:
>
> when cain->tmplt_ops != NULL and ...
>
> otherwise the commit message does not match the code.
>
My bad. I will submit a v2.
Thanks,
Hangyu
>> Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback")
>> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>> ---
>> net/sched/cls_api.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index 790d6809be81..51d175f3fbcb 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>> }
>>
>> if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {
>> + tfilter_put(tp, fh);
>> NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");
>> err = -EINVAL;
>> goto errout;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-21 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 8:58 [PATCH] net: sched: fix possible refcount leak in tc_new_tfilter() Hangyu Hua
2022-09-15 14:17 ` Vlad Buslov
2022-09-20 15:50 ` Jakub Kicinski
2022-09-21 9:08 ` Hangyu Hua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).