From: Kalle Valo <kvalo@kernel.org>
To: cgel.zte@gmail.com
Cc: toke@toke.dk, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>
Subject: Re: [PATCH V2] ath9k: Use platform_get_irq() to get the interrupt
Date: Mon, 14 Mar 2022 10:05:57 +0200 [thread overview]
Message-ID: <8735jlq7q2.fsf@kernel.org> (raw)
In-Reply-To: <877d8xqc2i.fsf@kernel.org> (Kalle Valo's message of "Mon, 14 Mar 2022 08:32:05 +0200")
Kalle Valo <kvalo@kernel.org> writes:
> cgel.zte@gmail.com writes:
>
>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>
>> It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
>> for requesting IRQ's resources any more, as they can be not ready yet in
>> case of DT-booting.
>>
>> platform_get_irq() instead is a recommended way for getting IRQ even if
>> it was not retrieved earlier.
>>
>> It also makes code simpler because we're getting "int" value right away
>> and no conversion from resource to int is required.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
>> ---
>> v1->v2:
>> - Retain dev_err() call on failure
>>
>> drivers/net/wireless/ath/ath9k/ahb.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
>> index cdefb8e2daf1..28c45002c115 100644
>> --- a/drivers/net/wireless/ath/ath9k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath9k/ahb.c
>> @@ -98,14 +98,12 @@ static int ath_ahb_probe(struct platform_device *pdev)
>> return -ENOMEM;
>> }
>>
>> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>> - if (res == NULL) {
>> + irq = platform_get_resource(pdev, 0);
>
> Is this really correct? Should it be platform_get_irq()?
>
> Do you compile test your patches? That's mandatory.
Also please fix your email setup, I get an error for this address:
<zealci@zte.com.cn>: host mxde.zte.com.cn[209.9.37.26] said: 550 5.1.1 User
unknown id=622EE16E.000 (in reply to RCPT TO command)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-03-14 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 6:26 [PATCH V2] ath9k: Use platform_get_irq() to get the interrupt cgel.zte
2022-03-14 6:32 ` Kalle Valo
2022-03-14 8:05 ` Kalle Valo [this message]
2022-03-14 9:26 ` cgel.zte
-- strict thread matches above, loose matches on Subject: below --
2022-03-14 6:45 cgel.zte
2022-03-14 9:55 ` Toke Høiland-Jørgensen
2022-03-18 15:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jlq7q2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).