From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61F5C072B5 for ; Fri, 24 May 2019 17:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7987F20863 for ; Fri, 24 May 2019 17:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731464AbfEXRKK (ORCPT ); Fri, 24 May 2019 13:10:10 -0400 Received: from mga02.intel.com ([134.134.136.20]:33571 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbfEXRKK (ORCPT ); Fri, 24 May 2019 13:10:10 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2019 10:10:09 -0700 X-ExtLoop1: 1 Received: from ellie.jf.intel.com (HELO ellie) ([10.54.70.22]) by fmsmga006.fm.intel.com with ESMTP; 24 May 2019 10:10:07 -0700 From: Vinicius Costa Gomes To: Willem de Bruijn , netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, Willem de Bruijn Subject: Re: [PATCH net-next v2] selftests/net: SO_TXTIME with ETF and FQ In-Reply-To: <20190523174846.84394-1-willemdebruijn.kernel@gmail.com> References: <20190523174846.84394-1-willemdebruijn.kernel@gmail.com> Date: Fri, 24 May 2019 10:10:08 -0700 Message-ID: <8736l3n5hr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Willem de Bruijn writes: > From: Willem de Bruijn > > The SO_TXTIME API enables packet tranmission with delayed delivery. > This is currently supported by the ETF and FQ packet schedulers. > > Evaluate the interface with both schedulers. Install the scheduler > and send a variety of packets streams: without delay, with one > delayed packet, with multiple ordered delays and with reordering. > Verify that packets are released by the scheduler in expected order. > > The ETF qdisc requires a timestamp in the future on every packet. It > needs a delay on the qdisc else the packet is dropped on dequeue for > having a delivery time in the past. The test value is experimentally > derived. ETF requires clock_id CLOCK_TAI. It checks this base and > drops for non-conformance. > > The FQ qdisc expects clock_id CLOCK_MONOTONIC, the base used by TCP > as of commit fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC"). > Within a flow there is an expecation of ordered delivery, as shown by > delivery times of test 4. The FQ qdisc does not require all packets to > have timestamps and does not drop for non-conformance. > > The large (msec) delays are chosen to avoid flakiness. > > Output: > > SO_TXTIME ipv6 clock monotonic > payload:a delay:28 expected:0 (us) > > SO_TXTIME ipv4 clock monotonic > payload:a delay:38 expected:0 (us) > > SO_TXTIME ipv6 clock monotonic > payload:a delay:40 expected:0 (us) > > SO_TXTIME ipv4 clock monotonic > payload:a delay:33 expected:0 (us) > > SO_TXTIME ipv6 clock monotonic > payload:a delay:10120 expected:10000 (us) > > SO_TXTIME ipv4 clock monotonic > payload:a delay:10102 expected:10000 (us) > > [.. etc ..] > > OK. All tests passed > > Changes v1->v2: update commit message output > > Signed-off-by: Willem de Bruijn > Acked-by: Eric Dumazet Acked-by: Vinicius Costa Gomes Cheers, -- Vinicius