From: Florian Fainelli <f.fainelli@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints
Date: Tue, 29 Aug 2017 09:46:05 -0700 [thread overview]
Message-ID: <8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com> (raw)
In-Reply-To: <1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>
On 08/28/2017 09:22 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> A few useful tracepoints to trace bridge forwarding
> database updates.
>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Small nit below, but probably not a candidate for a v3
> ---
> +
> + TP_printk("dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x",
Small nit, any particular reason why ndm_flags got a special treatment
with an equal character and not the other?
> + __get_str(dev), __entry->addr[0], __entry->addr[1],
> + __entry->addr[2], __entry->addr[3], __entry->addr[4],
> + __entry->addr[5], __entry->vid,
> + __entry->nlh_flags, __entry->ndm_flags)
--
Florian
next prev parent reply other threads:[~2017-08-29 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 4:22 [PATCH net-next v2] bridge: fdb add and delete tracepoints Roopa Prabhu
2017-08-29 10:13 ` Nikolay Aleksandrov
2017-08-29 13:36 ` Andrew Lunn
2017-08-29 13:49 ` Roopa Prabhu
2017-08-29 16:46 ` Florian Fainelli [this message]
2017-08-29 17:36 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737eb73-3437-5529-6f4d-7aa52c770357@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox