From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: [PATCH 2/3] irda: sh_irda: use devm_request_irq() Date: Tue, 07 Jan 2014 20:54:55 -0800 (PST) Message-ID: <8738kzxeci.wl%kuninori.morimoto.gx@gmail.com> References: <8761pvxedn.wl%kuninori.morimoto.gx@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, Kuninori Morimoto , Huqiu Liu To: "David S. Miller" Return-path: Received: from mail-pd0-f173.google.com ([209.85.192.173]:35305 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbaAHEy5 (ORCPT ); Tue, 7 Jan 2014 23:54:57 -0500 Received: by mail-pd0-f173.google.com with SMTP id p10so1285800pdj.18 for ; Tue, 07 Jan 2014 20:54:57 -0800 (PST) In-Reply-To: <8761pvxedn.wl%kuninori.morimoto.gx@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Kuninori Morimoto Huqiu reported current sh_irda driver doesn't call free_irq() in spite of using request_irq(). This patch replaces request_irq() into devm_request_irq() to solve this issue Reported-by: Huqiu Liu Signed-off-by: Kuninori Morimoto --- drivers/net/irda/sh_irda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/irda/sh_irda.c b/drivers/net/irda/sh_irda.c index ff45cd0..c96b46b 100644 --- a/drivers/net/irda/sh_irda.c +++ b/drivers/net/irda/sh_irda.c @@ -804,7 +804,7 @@ static int sh_irda_probe(struct platform_device *pdev) goto err_mem_4; platform_set_drvdata(pdev, ndev); - err = request_irq(irq, sh_irda_irq, 0, "sh_irda", self); + err = devm_request_irq(&pdev->dev, irq, sh_irda_irq, 0, "sh_irda", self); if (err) { dev_warn(&pdev->dev, "Unable to attach sh_irda interrupt\n"); goto err_mem_4; -- 1.7.9.5