From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH] net: cdc_ether: allow combined control and data interface Date: Fri, 28 Jun 2013 17:44:07 +0200 Message-ID: <8738s21bqw.fsf@nemi.mork.no> References: <1372432629-17245-1-git-send-email-bjorn@mork.no> <1419214.UqpcbE98T1@linux-5eaq.site> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Enrico Mioso To: Oliver Neukum Return-path: Received: from canardo.mork.no ([148.122.252.1]:43183 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511Ab3F1PoK convert rfc822-to-8bit (ORCPT ); Fri, 28 Jun 2013 11:44:10 -0400 In-Reply-To: <1419214.UqpcbE98T1@linux-5eaq.site> (Oliver Neukum's message of "Fri, 28 Jun 2013 17:32:25 +0200") Sender: netdev-owner@vger.kernel.org List-ID: Oliver Neukum writes: > On Friday 28 June 2013 17:17:08 Bj=C3=B8rn Mork wrote: >> Some Icera based Huawei modems handled by this driver are not >> completely CDC ECM compliant, using the same USB interface for both >> control and data. The CDC functional descriptors include a Union >> naming this interface as both master and slave, so it is supportable >> by relaxing the descriptor parsing in case these interfaces are >> identical. > > The disconnect handler is uselessly complex. Just return if the > interfaces are identical. There's nothing to do in that case. Right. Thanks. Will post a new version cleaning that up. Bj=C3=B8rn