From: Dan Smith <danms@us.ibm.com>
To: Oren Laadan <orenl@librato.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] c/r: Add AF_UNIX support (v8)
Date: Wed, 12 Aug 2009 08:36:17 -0700 [thread overview]
Message-ID: <873a7x59ji.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <4A82DFE0.4040108@librato.com> (Oren Laadan's message of "Wed\, 12 Aug 2009 11\:29\:36 -0400")
OL> Before pulling this one, I took a quick look at this patch, and I
OL> saw that it still uses skb_morph despite the changelog and my
OL> memory...
That's correct. We've been through several ways of allocating the
skb's, so it's definitely confusing. We're back to skb_morph()
because I'm pre-allocating them for lock safety when traversing the
queues. The only thing that is allocated is the actual skb structure
itself; the buffers are still shared like with skb_clone().
OL> 1) Move 'struct ckpt_hdr_socket' et-al to checkpoint_hdr.h
Okay, yeah, I guess we never really resolved the question of where
they really belong, but I'll put them back there for now.
OL> 2) Move everything that is af_unix specific from net/checkpoint.c
OL> to (a new) net/unix/checkpoint.c (prototypes probably in af_unix.h
OL> ?)
Um, I guess I can. That will end up with a bunch of other
externally-defined interfaces between the generic and the specific
code, but I suppose I don't really have a solid argument against it.
OL> 3) Make sure that af_unix code does not compile (and is not called
OL> from net/checkpoint.c) unless CONFIG_UNIX is defined.
Okay.
OL> I pulled all the other patches already, will add this one once
OL> you resend.
Alright, well, ignore v9 I guess and hopefully we can settle on a nice
even number 10 :)
--
Dan Smith
IBM Linux Technology Center
email: danms@us.ibm.com
next prev parent reply other threads:[~2009-08-12 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1249918379-29414-1-git-send-email-danms@us.ibm.com>
2009-08-10 15:32 ` [PATCH 3/5] Add common socket helpers to unify the security hooks Dan Smith
2009-08-10 15:32 ` [PATCH 5/5] c/r: Add AF_UNIX support (v8) Dan Smith
2009-08-10 21:02 ` Serge E. Hallyn
2009-08-10 21:06 ` Dan Smith
2009-08-12 15:29 ` Oren Laadan
2009-08-12 15:36 ` Dan Smith [this message]
2009-08-12 19:19 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a7x59ji.fsf@caffeine.danplanet.com \
--to=danms@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=orenl@librato.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).