From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>, edward.cree@amd.com
Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
habetsm.xilinx@gmail.com, marcelo.leitner@gmail.com,
Edward Cree <ecree.xilinx@gmail.com>
Subject: Re: [RFC PATCH v2 net-next 1/3] netlink: add support for formatted extack messages
Date: Thu, 13 Oct 2022 18:16:47 +0200 [thread overview]
Message-ID: <873a9e2e933cd811a72f9a06cc97e9f014bc94cd.camel@sipsolutions.net> (raw)
In-Reply-To: <20221013082913.0719721e@kernel.org>
On Thu, 2022-10-13 at 08:29 -0700, Jakub Kicinski wrote:
>
> I'd do:
>
> pr(extack formatting overflow $__FILE__:$__func__:$__LINE__ $needed_len)
>
> (I think splicing the "trunced extack:" with fmt will result
> in the format string getting stored in .ro twice?)
>
If you worry about the strings (and sizes) then you probably shouldn't
advocate always having __FILE__ and __func__ ;-)
FWIW, my argument earlier was that if we have the truncated string
a) it lets you recover better in a live system
b) the message ought to be enough to figure out where the issue is, and
if the message isn't unique you probably have the problem twice too
But yeah, I'm with "take it or leave it", it all doesn't matter that
much.
johannes
next prev parent reply other threads:[~2022-10-13 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:22 [RFC PATCH v2 net-next 0/3] netlink: formatted extacks edward.cree
2022-10-13 9:23 ` [RFC PATCH v2 net-next 1/3] netlink: add support for formatted extack messages edward.cree
2022-10-13 15:29 ` Jakub Kicinski
2022-10-13 16:16 ` Johannes Berg [this message]
2022-10-13 16:32 ` Jakub Kicinski
2022-10-17 12:04 ` Edward Cree
2022-10-17 18:40 ` Jakub Kicinski
2022-10-13 9:23 ` [RFC PATCH v2 net-next 2/3] sfc: use formatted extacks instead of efx_tc_err() edward.cree
2022-10-13 9:23 ` [RFC PATCH v2 net-next 3/3] sfc: remove 'log-tc-errors' ethtool private flag edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a9e2e933cd811a72f9a06cc97e9f014bc94cd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).