netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: Control group classifier
Date: Thu, 16 Oct 2008 07:41:55 +0200	[thread overview]
Message-ID: <873aixksf0.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081013155715.GZ20815@postel.suug.ch> (Thomas Graf's message of "Mon, 13 Oct 2008 17:57:16 +0200")

Thomas Graf <tgraf@suug.ch> writes:
>
> The principle of the classifier is to directly access the
> task_struct via get_current(). In order for this to work,
> classification requests from softirqs must be ignored.

You mean the classifier just wants to know if it runs
as a softirq?

> This is
> not a problem because the vast majority of packets in softirq
> context are not assigned to a task anyway. For this to work, a
> mechanism is needed to trace softirq context.
> The only existing
> way to do so is to use the TRACE_IRQFLAGS feature, unfortunately

Does't softirq_count() > 0 check that?

-Andi

-- 
ak@linux.intel.com

  parent reply	other threads:[~2008-10-16  5:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13 15:57 [PATCH] pkt_sched: Control group classifier Thomas Graf
2008-10-14 11:56 ` Chei-yol Kim
2008-10-14 17:00   ` Thomas Graf
2008-10-14 17:03   ` Thomas Graf
2008-10-16  5:41 ` Andi Kleen [this message]
2008-10-17 18:23   ` Thomas Graf
2008-10-17 18:32     ` Andi Kleen
2008-10-17 20:09       ` Thomas Graf
2008-10-18  5:38         ` Andi Kleen
2008-10-19 17:00           ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873aixksf0.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).