netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
	e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/5] e1000e: Add interrupt moderation run-time ethtool interface
Date: Mon, 14 Apr 2008 21:24:06 +0200	[thread overview]
Message-ID: <873apoutnt.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080414170604.23286.86187.stgit@localhost.localdomain> (Auke Kok's message of "Mon, 14 Apr 2008 10:06:04 -0700")

Auke Kok <auke-jan.h.kok@intel.com> writes:

> The ethtool -c / -C interface can now be used to modify the
> irq moderation algorithm. This change does not require an
> adapter reset and can thus be used at all times. The adapter
> only supports changing/reading rx-usecs which has special
> values for 0, 1 and 3:
>
> 0 - no irq moderation whatsoever
> 1 - normal moderation favoring regular mixed traffic (default)
> 3 - best attempt at low latency possible at cost of CPU

It would be nice if ethtool instead of having this as a obscure magic
number had a higher level "--low-latency" or similar parameter
(that could also potentially set similar settings on other NICs)

You think there would be a clean way to implement this? 

-Andi

  reply	other threads:[~2008-04-14 19:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 17:05 [PATCH 1/5] e1000e: cleanup several stats issues Auke Kok
2008-04-14 17:06 ` [PATCH 2/5] e1000e: Add interrupt moderation run-time ethtool interface Auke Kok
2008-04-14 19:24   ` Andi Kleen [this message]
2008-04-14 19:31     ` Rick Jones
2008-04-14 19:35     ` Jeff Garzik
2008-04-14 19:53       ` Andi Kleen
2008-04-14 20:09       ` Kok, Auke
2008-04-14 17:06 ` [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device Auke Kok
2008-04-14 17:11   ` Patrick McHardy
2008-04-17 21:45     ` Kok, Auke
2008-04-21 14:24       ` Patrick McHardy
2008-04-22  7:46         ` Waskiewicz Jr, Peter P
2008-04-30  0:42         ` Waskiewicz Jr, Peter P
2008-04-30  6:54           ` Patrick McHardy
2008-04-30  6:56             ` Patrick McHardy
2008-04-14 17:06 ` [PATCH 4/5] e1000e: Fix HW Error on es2lan, ARP capture issue by BMC Auke Kok
2008-04-14 17:06 ` [PATCH 5/5] e1000e: lower ring minimum size to 64 Auke Kok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873apoutnt.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=auke-jan.h.kok@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).