From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitsuru KANDA / =?ISO-2022-JP?B?GyRCP0BFRBsoQiAbJEI9PBsoQg==?= Subject: Re: [PATCH] IPv6 IPComp Date: Sat, 17 May 2003 02:59:30 +0900 Sender: netdev-bounce@oss.sgi.com Message-ID: <873cjebwn1.wl@karaba.org> References: <87llx72imk.wl@karaba.org> Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Cc: netdev@oss.sgi.com, usagi@linux-ipv6.org Return-path: To: jmorris@intercode.com.au, davem@redhat.com, kuznet@ms2.inr.ac.ru In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org At Fri, 16 May 2003 23:40:18 +1000 (EST), James Morris wrote: ... > > Attached diff is for linux-2.5.69 + CS1.1137 . > > > > Could you check it? > > > > Looks good! Thank you! > A few issues: > > The crypto/Kconfig file needs to be updated so that the deflate module is > enabled when ipcomp6 is. OK, I will send a small patch after this ipcomp6 patch is committed. > In a subsequent patch, it would be good to define single NIP6() in a > header file, as local versions are spreading. Yes, this is a next issue for me. I have a plan to do various small cleanups w/r AH6/ESP6/IPComp6... > With current bk, you need to attach internal ipip xfrms to allow reception > of uncompressed ipcomp packets in tunnel mode. See the current ipv4 > ipcomp code as an example. Any generic code for this should probably live > in net/xfrm/xfrm_tunnel.c I think so, but it may take a time because currently ip6ip6 does not exist. Regards, -mk