From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D003EBF04 for ; Fri, 30 Jan 2026 13:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769780492; cv=none; b=OJIvYWD69Vi2pk9qofOs3j9Y72rIvFShMAWHe0UW1pET4TPBFG9isdfOmiDciR+wFdOCe46nT7HNSBBQMJ36KlCOvwgw8FPHD0zfZ6HUzsDJZ9Eyqb/h6OyZCGbmVsGaIgB1hOr5Jflh173F76zE3h9+6DslOYb6ZqU3Oq7VTG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769780492; c=relaxed/simple; bh=6FsHRzd7wh8PvCwk7n6nKCZEIEPbDL/cQG0WAumT5iA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K6WdcbxErpV/NUhyqTP8wYxBjLiphR0g+uTfm7hN+suEbDzGJMOhtPAXuAX1bihf/mhiKzdwU0RDJ+W3LI7orLBUiKlCyW0e9WIDKvXxytBvzlAEtyGp8k4nOEz1GEEeSWEc5kLEMsAVNYU09y1SCkOZUiQsPwiqfNHAfIFvXkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OshYGjNO; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OshYGjNO" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 53B1D1A2B3A; Fri, 30 Jan 2026 13:41:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 246C26075A; Fri, 30 Jan 2026 13:41:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9C4DE119A885C; Fri, 30 Jan 2026 14:41:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769780488; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=TxIA3Fag8gqy+7Gr2vgkUxxZMZWgXcdj2sE3kyvxrtM=; b=OshYGjNOI8uT264Wv8fROQ5dotDBe4P5mpasX/mFCf3HgmQozru5SyFyKDy3vhucSH6yAk tTQLsYjxAT9Ie11untOl64hQsbD6Ekb5QLngiwWrhG+JQUlzU25n1zZz1Mb4l3+tGAEKV9 Jb4MmSVxq6fnbh3LGP6jkUaT1dF75YK/keSKD3g92ouQBwbCWJEZ3hl7jzqxSuQwmkqYFS UaGs9XL37nhuQP0UWxryU+6O7nsN7YPeMyp70lUeVP5joMlkPlfh1MU8vDs9V9YSVrNq6r OJLnJRFlGnU2xjvfLjVyVJaa0CcVsGO9b2C1wTeQ5raZ0wF3wzlQ4viD36d2rQ== Message-ID: <874d4b28-754d-47b8-a207-9b73db403dba@bootlin.com> Date: Fri, 30 Jan 2026 14:41:22 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 10/13] net: phy: phy_link_topology: Add a helper to retrieve ports To: Romain Gantois , davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Daniel Golle , Dimitri Fedrau References: <20260127134202.8208-1-maxime.chevallier@bootlin.com> <20260127134202.8208-11-maxime.chevallier@bootlin.com> <7904208.EvYhyI6sBW@fw-rgant> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <7904208.EvYhyI6sBW@fw-rgant> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 28/01/2026 17:10, Romain Gantois wrote: > On Tuesday, 27 January 2026 14:41:58 CET Maxime Chevallier wrote: >> In order to allow netlink access to phy_ports, let's add a helper to >> retrieve them. When handling a port coming from phy_link_topology, the >> caller must hold rtnl until it's done with it. > > Why not use rtnl-specific lockdep annotations to make this more explicit? While this makes sure the call-site holds the lock as it should, it doesn't guarantee the caller won't release it too early. Doesn't hurt to add it though :) Maxime > > Thanks, >