Netdev List
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn@kernel.org>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Alexander Duyck <alexanderduyck@fb.com>,
	Jakub Kicinski <kuba@kernel.org>,
	kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	Eric Dumazet <edumazet@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	Mohsin Bashir <hmohsin@meta.com>,
	"Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Bobby Eshleman <bobbyeshleman@meta.com>,
	Breno Leitao <leitao@debian.org>, Simon Horman <horms@kernel.org>,
	Mina Almasry <almasrymina@google.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Dimitri Daskalakis <daskald@meta.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
Subject: Re: [PATCH net v2 1/5] eth: fbnic: wait on the correct queues in fbnic_queue_stop()
Date: Wed, 18 Nov 2026 14:13:24 +0100	[thread overview]
Message-ID: <874ide8eq3.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <20261117215416.1901246-2-dimitri.daskalakis1@gmail.com>

Dimitri Daskalakis <dimitri.daskalakis1@gmail.com> writes:

> From: Dimitri Daskalakis <daskald@meta.com>
>
> fbnic_queue_stop() waits for every queue of the NAPI vector to go idle
> before tearing it down, using sub0.q_idx as the queue index. We set
> q_idx on submission queues for Tx, and completion queues on Rx, so
> this waits on queue 0 for every Rx queue.
>
> For non-combined channels, stopping an Rx queue always stops/wakes
> Tx queue 0.
>
> Set the queue id on Tx completion rings so we don't have to distinguish
> between ring types to get the correct queue id, and don't stop/wake
> disabled rings.
>
> This bug was found by AI and verified on HW.

The LLMs I run complained about this as well -- nice to see it verified
on HW. Also, this fix is much cleaner than what my clanker suggested!

Reviewed-by: Björn Töpel <bjorn@kernel.org>

  reply	other threads:[~2026-11-18 13:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 21:54 [PATCH net v2 0/5] eth: fbnic: miscellaneous driver fixes Dimitri Daskalakis
2026-11-17 21:54 ` [PATCH net v2 1/5] eth: fbnic: wait on the correct queues in fbnic_queue_stop() Dimitri Daskalakis
2026-11-18 13:13   ` Björn Töpel [this message]
2026-11-17 21:54 ` [PATCH net v2 2/5] eth: fbnic: skip disabled Tx rings when setting the queue NAPI Dimitri Daskalakis
2026-11-18 13:15   ` Björn Töpel
2026-11-17 21:54 ` [PATCH net v2 3/5] eth: fbnic: skip freed Tx rings in fbnic_get_ts_stats() Dimitri Daskalakis
2026-11-17 21:54 ` [PATCH net v2 4/5] netdevsim: report fake timestamping stats Dimitri Daskalakis
2026-11-17 21:54 ` [PATCH net v2 5/5] selftests: drv-net: stats: query timestamping stats while down Dimitri Daskalakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ide8eq3.fsf@all.your.base.are.belong.to.us \
    --to=bjorn@kernel.org \
    --cc=alexanderduyck@fb.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bobbyeshleman@meta.com \
    --cc=daskald@meta.com \
    --cc=davem@davemloft.net \
    --cc=dimitri.daskalakis1@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=hmohsin@meta.com \
    --cc=horms@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mike.marciniszyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox