From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F81221FCD for ; Tue, 10 Feb 2026 11:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770724082; cv=none; b=esuCOLL3nEZMdeE52z+6Go14IJ8FSoL+IV20C6XJKIIL9DRDMQw/0A1SWZcelQ7kZd/urIB8u29q0kDy6kq2jaqHezPFqVX81NMdJLSmrG2iyIppuCp+IelK9YhqmZUyLGQNdl//l8WnqjR2kjHfuBN377lJn0U0wSxDJ5B6oZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770724082; c=relaxed/simple; bh=eHQC/1uXNqG8Cq4bOsObpnrSbfAgHkc+3G/800mPjiI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ub9eVFeUNJRx82+5CAc0/nvQf1/19wZc9p3qltB2K1SgzCitq6CHUfzoSpc4HKNyR1pIsrKbrep0vNyu7zIIoBKn8JiMKz8xw+Ayp346snk9LeH85neQiBazXxvp7BnjiAvbFFYSDerUW8pHHQhzceu/yR5Jr0GJRqzdHoPdE6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KfGfLXUL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fkzdv587; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KfGfLXUL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fkzdv587" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770724080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EN/yPGhkQUnfeD5ks5Tmc7VGBgpgQUKl1WzPpgUbvpA=; b=KfGfLXULk/vmtgZII3gxuHZh0XQhkzmp3M9PUVGLuXqihpPQaSry9kVc/gm1urN9r/Y50V y8wLuDSqZ0izRIvwRgarsfBqWGPP5DpwVi4zC9xzMmR8jiujwMIxd0EKEffD48Mn0voLpY MTmmarqdOau37j8p95VFaXsWmRQV3Dk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-J3BvUPbdOy-zRnv39NWThQ-1; Tue, 10 Feb 2026 06:47:58 -0500 X-MC-Unique: J3BvUPbdOy-zRnv39NWThQ-1 X-Mimecast-MFC-AGG-ID: J3BvUPbdOy-zRnv39NWThQ_1770724078 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47ee432070aso38587925e9.1 for ; Tue, 10 Feb 2026 03:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770724077; x=1771328877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=EN/yPGhkQUnfeD5ks5Tmc7VGBgpgQUKl1WzPpgUbvpA=; b=Fkzdv587cKgupKnrT/veRzfUsxtVPY54O/2lSgHGXu8odgyQxm10Mi+xD6AlCRpF4n WTvOQIXHnADCLVqAsofIQfyKdTDvJCf/wfugR1QK5Pv7iaEeJsXa6yjIKKFssrguhbmU htOL7PDIidANjHG3taPmnrJOu2zIaQ3KvNpHG21xsgRAqlkGpYaO8vhNtzqIOVf8Eob1 iB3n+cIzfHMJmJ9Y5dIVTH2ieqo1BzR6FZEicw4nIQRapGnPg/VLfBCoxfRe1TVvtM4b KSw2CG/NA98v7LwyTcpz3cB1Ly6evwDjnYvnG+etQPZmJTrQYZWWMhsx2sTJGIoEJB3A hF9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770724077; x=1771328877; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EN/yPGhkQUnfeD5ks5Tmc7VGBgpgQUKl1WzPpgUbvpA=; b=l75o0XipxO170oVUbLtt2BwW7Jyrv8hZVpiJMuLqnTmC4ob0CSSAxVRX+R7jMV2hjJ hw5gkMKycjjcB7UWRsvmrKt9IICDihsmZKa4dTnS+NS8vuD4NjIiyHc8xTaYy0d2eZXf 7Ev/LtRcA8/02Z8JxT1Mu108Gn9VdaUcP3ZQHoStYjCIL+EcOfwNNAahfPc89KT9m+/X WdvxlKDx3BezXmjYMDIfvuaQrT+0Vd2ggWgnaWreNU+rXwuh3gMCxrd4M7m5pwF58nYN O5BIIrXA07BWZb3J2/OzI+AY192esLO3X+Ab8X+SK+YmFc7Bi6mcXKUZKd6yrfp2136n +aeg== X-Forwarded-Encrypted: i=1; AJvYcCWceL5lnMoVfEdj4vT8kfPe3oLThs9WkoJqxtHBRdkCgDXuXxQt9j87KpzrgQbQLV+lDvuZ6bM=@vger.kernel.org X-Gm-Message-State: AOJu0YywUtW64rNek1cIxSQ37be1TXFgQcRWz1qS3Dz6OAs1GDdTu3iu pD6/hSJVKDWX2Cicgbz11BTqjLxD2nGY+sIV4XBY9I6G9u3+up+7006qmC48EAabPGzzOK+WDQv L8tfMINWWe9xElD01xrU1pV1CAGbHUhYbi2gjBsa/lUcpBvtDdQ74XyRLrw== X-Gm-Gg: AZuq6aKjWJ+o8xxN9p3ovFJVe4KsJjPjFlkOGwauylnG+7EZXlP70wV31jmlXF+EpK2 VD0616RFLNeNcpU20g7vK6tWJIRF3C2R4Az6B3RPBTBXie6Sao7coP8pyJjCJLPthwCQKXMVEdP w3+sb625Dr+pdlZA28bYewAgyEDS0duojoHWzIiIVfUH/IPoHAlmK9xJAcI1ZqMoFgUswuHXql2 AC61A9vHCducNvOcdTmmqEGEzg+xZje8BQMlxKBXaaNwumI27WKdenTPXBJcHk34UtZIEMPUDlQ SJBJIoLFFHaI3qx24XjLjfrBo1mMy6ndJhZh7EE+rwRURjLskc4Xbx28czn/ErsPX1hNbnbmiyh 9dSLiHOP3bLhTuuNPBd1u2jtR4uYmegSZJNsTqM6UOK7+IA== X-Received: by 2002:a05:600c:630f:b0:482:dbd7:a1c1 with SMTP id 5b1f17b1804b1-48320226287mr213039475e9.34.1770724077574; Tue, 10 Feb 2026 03:47:57 -0800 (PST) X-Received: by 2002:a05:600c:630f:b0:482:dbd7:a1c1 with SMTP id 5b1f17b1804b1-48320226287mr213039065e9.34.1770724077144; Tue, 10 Feb 2026 03:47:57 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436297462a8sm31436401f8f.30.2026.02.10.03.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 03:47:56 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7BC834FE897; Tue, 10 Feb 2026 12:47:54 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jesper Dangaard Brouer , netdev@vger.kernel.org, Eric Dumazet , "David S. Miller" , Paolo Abeni Cc: Jesper Dangaard Brouer , bpf@vger.kernel.org, Jakub Kicinski , horms@kernel.org, jiri@resnulli.us, edumazet@google.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, atenart@redhat.com, carges@cloudflare.com, kernel-team@cloudflare.com Subject: Re: [PATCH net-next v3 1/6] net: sched: introduce qdisc-specific drop reason tracing In-Reply-To: <177039506239.2258217.7863252279149995024.stgit@firesoul> References: <177039500964.2258217.2989656069254156812.stgit@firesoul> <177039506239.2258217.7863252279149995024.stgit@firesoul> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 10 Feb 2026 12:47:54 +0100 Message-ID: <874inozuol.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jesper Dangaard Brouer writes: > Create new enum qdisc_drop_reason and trace_qdisc_drop tracepoint > for qdisc layer drop diagnostics with direct qdisc context visibility. > > The new tracepoint includes qdisc handle, parent, kind (name), and > device information. Existing SKB_DROP_REASON_QDISC_DROP is retained > for backwards compatibility via kfree_skb_reason(). > > Convert FQ, FQ_CoDel, CoDel, SFB, and pfifo_fast to use the new > infrastructure. > > Reported-by: syzbot+ci335f183b8446659a@syzkaller.appspotmail.com > Signed-off-by: Jesper Dangaard Brouer One small nit, see below. With that: Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen [...] > @@ -37,6 +37,31 @@ > const struct Qdisc_ops *default_qdisc_ops =3D &pfifo_fast_ops; > EXPORT_SYMBOL(default_qdisc_ops); >=20=20 > +void tcf_kfree_skb_list(struct sk_buff *skb, struct Qdisc *q, > + struct netdev_queue *txq, struct net_device *dev) > +{ > + while (unlikely(skb)) { Seems a bit odd to have the unlikely() here. I guess it was originally there because it was an inlined function, but since it isn't anymore (presumably?), does it really do anything? -Toke