From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: Keisuke Nishimura <keisuke.nishimura@inria.fr>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] ieee802154: ca8210: Add missing check for kfifo_alloc() in ca8210_probe()
Date: Mon, 11 Nov 2024 20:36:16 +0100 [thread overview]
Message-ID: <874j4dr2a7.fsf@bootlin.com> (raw)
In-Reply-To: <20241108133901.GD4507@kernel.org> (Simon Horman's message of "Fri, 8 Nov 2024 13:39:01 +0000")
Hello,
>> > On Tue, Oct 29, 2024 at 07:27:12PM +0100, Keisuke Nishimura wrote:
>> >> ca8210_test_interface_init() returns the result of kfifo_alloc(),
>> >> which can be non-zero in case of an error. The caller, ca8210_probe(),
>> >> should check the return value and do error-handling if it fails.
>> >>
>> >> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Stable tag missing.
With this fixed,
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2024-11-11 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 18:27 [PATCH] ieee802154: ca8210: Add missing check for kfifo_alloc() in ca8210_probe() Keisuke Nishimura
2024-11-04 12:12 ` Simon Horman
2024-11-04 22:24 ` Keisuke Nishimura
2024-11-08 13:39 ` Simon Horman
2024-11-11 19:36 ` Miquel Raynal [this message]
2024-11-19 10:06 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j4dr2a7.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=keisuke.nishimura@inria.fr \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).