From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E54288BD; Mon, 17 Jun 2024 09:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718616589; cv=none; b=PooSObC+4rR/ebvgtjay64wdfEfB8d4xVK/QEYgm3TqiMW9ufN12XbOrBnDtTEHet72fKLxBt8GTuR5ns0Rs+Q6F94CANgAIOGV72iGLSi8Tj44xdVnA4BarAL12OPnUrbcilOzq7oW4Z35g6ApQTjulEldX/Cdgtr7jy7y5Z2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718616589; c=relaxed/simple; bh=at9csQjhwS6i1s/d4XG/8Zpj8DRi4xJ/ag+5eIwgDXc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=GSJFgkvGeupIyIzEJXIbnsmB8IXKlNlJMaoG9zkUfvA1d9nQRIe5fYDvpxVUxzGcDt9LgTgRA6oZPBk9zOWCO/PMKOR9/AJLxwJW1a/jYUZxpydEFCnn48vSqptRGigrQmkHFIgYjNAFYncGlSzvI6F/CPCfX26vBN7QdoiJY3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E/mPGHpM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E/mPGHpM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7837C2BD10; Mon, 17 Jun 2024 09:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718616588; bh=at9csQjhwS6i1s/d4XG/8Zpj8DRi4xJ/ag+5eIwgDXc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=E/mPGHpMeIKgElg+Cpbw7Fc4U13Fmjr/ou+tMopM8OI/rDuDdPcOl4diV6dshwHhQ 3sNv1Ke/lo5tm3ytKne5KNNO2Yd/NG5GnuCLOuBIioWeNHZSFi6d0iSOde+dXx/B6j 3whdRSvwmZH1N2Ue9vGwp3EaecJaqm5pKb/q6LtrvJI6tJpV93fkKvzL9+vkwzp6vx 8L8/gSlYRXdmAFPtQ01t2G0VPY93VsyiGdmB1XI/MsoVst8nV+XnNF86IcCpni81i9 xHSp07ojBZM0bm9x6EbEbQmOcqic7F7aUAtsulWym9myGefvcAHF9vMNFWTPJf/CQK v1oZos6Ur+BYg== From: Kalle Valo To: Breno Leitao Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, horms@kernel.org, kees@kernel.org, kuba@kernel.org, Bo Jiao , Daniel Golle , Alexander Couzens , Deren Wu , Ming Yen Hsieh , Leon Yen , Quan Zhou , Ingo Rohloff , Sujuan Chen , StanleyYP Wang , Benjamin Lin , Peter Chiu , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH] wifi: mt76: un-embedd netdev from mt76_dev References: <20240614115317.657700-1-leitao@debian.org> <87cyogkkju.fsf@kernel.org> Date: Mon, 17 Jun 2024 12:29:42 +0300 In-Reply-To: (Breno Leitao's message of "Mon, 17 Jun 2024 02:22:23 -0700") Message-ID: <874j9rlxx5.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Breno Leitao writes: > Hello Kalle, > > On Mon, Jun 17, 2024 at 12:03:49PM +0300, Kalle Valo wrote: >> Breno Leitao writes: >> >> > Embedding net_device into structures prohibits the usage of flexible >> > arrays in the net_device structure. For more details, see the discussion >> > at [1]. >> > >> > Un-embed the net_devices from struct mt76_dev by converting them >> > into pointers, and allocating them dynamically. Use the leverage >> > alloc_netdev_dummy() to allocate the net_device object at >> > mt76_dma_init(). >> > >> > The free of the device occurs at mt76_dma_cleanup(). >> > >> > Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1] >> > Signed-off-by: Breno Leitao >> > --- >> > >> > PS: Due to the lack of hardware, this patch was not tested on a real >> > hardware, unfortunately. >> > >> > PS2: this is the last driver that is still using embedded netdevices. >> >> Is this patch a dependency to other patches? I'm asking because it will >> be _slow_ to get this patch to net-next via wireless trees. If there's >> urgency then it's much better to take it directly to net-next (of course >> with acks from Felix and Lorenzo). > > Since this is the last patch for the whole flexible netdev work, I would > prefer to have it through net-next then, so, we finish the whole work > sooner rather than later. Ok, even though I hate dealing with conflicts between trees I still think it's better to get this directly to net-next. I hate "hurry up!" emails even more ;) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches