From: "Björn Töpel" <bjorn@kernel.org>
To: Zachary Leaf <zachary.leaf@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn@rivosinc.com>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
linux-kselftest@vger.kernel.org,
"Anders Roxell" <anders.roxell@linaro.org>,
linux-morello@op-lists.linaro.org,
"Quentin Monnet" <quentin@isovalent.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Cross-compile bpftool
Date: Tue, 14 Feb 2023 10:41:02 +0100 [thread overview]
Message-ID: <874jroa8k1.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <88a5c080-b5fc-f78a-af9e-eb8af66149ec@arm.com>
Zachary Leaf <zachary.leaf@arm.com> writes:
> Hi Bjorn,
>
> Thanks for the patch, I've tested it and it works for me.
Good!
> I have a minor suggestion but otherwise happy to see this getting fixed.
>
> ...
>
>
> -TEST_GEN_PROGS_EXTENDED += $(DEFAULT_BPFTOOL)
> +TEST_GEN_PROGS_EXTENDED += $(TRUNNER_BPFTOOL)
>
> Ensure the target arch bpftool is copied into the kselftest_bpf_install
> dir by selftests/lib.mk instead of always the default/host version.
Good one. I'll spin a v2, and also fix Quentin's "double-slash".
Björn
prev parent reply other threads:[~2023-02-14 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 8:43 [PATCH bpf-next] selftests/bpf: Cross-compile bpftool Björn Töpel
2023-02-13 14:30 ` Björn Töpel
2023-02-14 9:16 ` Zachary Leaf
2023-02-14 9:44 ` Björn Töpel
2023-02-13 20:53 ` Quentin Monnet
2023-02-14 9:46 ` Jean-Philippe Brucker
2023-02-14 8:57 ` Zachary Leaf
2023-02-14 9:41 ` Björn Töpel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jroa8k1.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jean-philippe@linaro.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-morello@op-lists.linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=zachary.leaf@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox