From: Kurt Kanzenbach <kurt@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: hellcreek: Print warning only once
Date: Mon, 05 Sep 2022 14:28:46 +0200 [thread overview]
Message-ID: <874jxmj98h.fsf@kurt> (raw)
In-Reply-To: <a1b21de9-a379-f920-e7d1-07ac7f5a7e96@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
>> static void dwmac1000_core_init(struct mac_device_info *hw,
>> struct net_device *dev)
>
> You should be able to remove the net_device reference here since we do
> not use it anymore after the removal of netdev_uses_dsa() or
> de-referencing of priv.
That's true for dwmac1000_core_init(). However, dwmac4_core_init() is
using priv now for some timestamping waitqueue initialization.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-09-05 12:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:34 [PATCH net-next] net: dsa: hellcreek: Print warning only once Kurt Kanzenbach
2022-08-30 19:04 ` Andrew Lunn
2022-08-31 15:26 ` Vladimir Oltean
2022-08-31 19:34 ` Kurt Kanzenbach
2022-08-31 23:43 ` Vladimir Oltean
2022-09-01 6:21 ` Kurt Kanzenbach
2022-09-01 11:39 ` Vladimir Oltean
2022-09-03 13:24 ` Kurt Kanzenbach
2022-09-03 16:44 ` Vladimir Oltean
2022-09-03 17:25 ` Florian Fainelli
2022-09-05 12:28 ` Kurt Kanzenbach [this message]
2022-09-01 2:55 ` Jakub Kicinski
2022-09-01 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jxmj98h.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).