Re: [PATCH] net: mvpp2: add delay at the end of .mac_prepare

Baruch Siach
2022-05-01T11:49:16Z

Hi Russell,

On Sun, May 01 2022, Russell King (Oracle) wrote:
> Please trim so I don't have to waste my vital limited power reading
> paging through lots of unnecessary text. Thanks.
>
> On Thu, Apr 28, 2022 at 11:03:08PM +0300, Baruch Siach wrote:
>> mv88x3310 f212a600.mdio-mii:02: Firmware version 0.3.10.0
>>
>> This is a timing sensitive issue. Slight change in firmware code might
>> be significant.
>
> That should be new enough to avoid the firmware problem - and it seems
> that 0.3.10.0 works fine on the Macchiatobin DS.
>
>> One more detail that might be important is that the PHY firmware is
>> loaded at run-time using this patch (rebased):
>>
>> https://lore.kernel.org/all/13177f5abf60215fb9c5c4251e6f487e4d0d7ff0.1587967848.git.baruch@tkos.co.il/
>
> Hmm, I wonder what difference that makes...
>
> Can you confirm the md5sum of your firmware please?
> 95180414ba23f2c7c2fabd377fb4c1df ?

Precisely:

$ md5sum x3310fw_0_3_10_0_10860.hdr
95180414ba23f2c7c2fabd377fb4c1df x3310fw_0_3_10_0_10860.hdr

Thanks,
baruch

--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -