From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6E3C433EF for ; Wed, 27 Oct 2021 06:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3238A60F0F for ; Wed, 27 Oct 2021 06:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238516AbhJ0GWk (ORCPT ); Wed, 27 Oct 2021 02:22:40 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:42508 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238500AbhJ0GWj (ORCPT ); Wed, 27 Oct 2021 02:22:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1635315615; h=Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From: Sender; bh=ps8/xgtg5gAKrPPoVBISwY+vty6tFr8afONeYrw77Eg=; b=UcBxF9svUb0n236P3VfJBYe1IALtKuiqFwIckadXpeNh6UDYwO3VGG35rhtk/Dj56AzanNaj cikDfLXcyUmyhHs0GO+BqBwgfy+VrfAv2YhNF7+z6dlqi1wLlB9CZVmkJZpTR6dqx6dz48H2 VGOKDI5a/47KvYfEDUC7wma9NGk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 6178ef9a321f2400513e92fd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 Oct 2021 06:20:10 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C7AB5C43617; Wed, 27 Oct 2021 06:20:10 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 253AFC4338F; Wed, 27 Oct 2021 06:20:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 253AFC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , Arnd Bergmann , Ryder Lee , Shayne Chen , Sean Wang , "David S. Miller" , Jakub Kicinski , Matthias Brugger , YN Chen , Deren Wu , Leon Yen , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76: mt7663s: fix link error with CONFIG_PM=n In-Reply-To: <20211026083326.3421663-1-arnd@kernel.org> (Arnd Bergmann's message of "Tue, 26 Oct 2021 10:33:09 +0200") References: <20211026083326.3421663-1-arnd@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 27 Oct 2021 09:20:03 +0300 Message-ID: <874k939egc.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > The generic register access functions are compiled conditionally, > causing a link failure in some randconfig builds: > > ERROR: modpost: "mt76_connac_mcu_reg_wr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined! > ERROR: modpost: "mt76_connac_mcu_reg_rr" [drivers/net/wireless/mediatek/mt76/mt7615/mt7663s.ko] undefined! > > Move them out of the #ifdef block. > > Fixes: 02fbf8199f6e ("mt76: mt7663s: rely on mcu reg access utility") > Signed-off-by: Arnd Bergmann Felix already submitted an identical patch: https://patchwork.kernel.org/project/linux-wireless/patch/20211023112407.26448-1-nbd@nbd.name/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches