From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC38C4727D for ; Thu, 24 Sep 2020 14:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD8E32395C for ; Thu, 24 Sep 2020 14:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y9C9T1JE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728250AbgIXOe5 (ORCPT ); Thu, 24 Sep 2020 10:34:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43392 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728088AbgIXOe5 (ORCPT ); Thu, 24 Sep 2020 10:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600958095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3HqrxwHoOSHrlwkdSsVQFFgcglebPJHiA/TqTJru7b8=; b=Y9C9T1JEXYyNdtw2hjnpEbSUP6moiGDQK4XGPGskoWyPggd2Br5iHV/OJ6WAFoF1xXdStT qmUBXLxskBKEAfLbNbvu+DLwawrEhTrq7hcmPC/Od3eCgFliEt3vnbGHdjkHZC6mSzofWC PZa/SkdbIydchx9DKU+JylVMvXr10oo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-zIUm1CKQODynO2-tf750fg-1; Thu, 24 Sep 2020 10:34:54 -0400 X-MC-Unique: zIUm1CKQODynO2-tf750fg-1 Received: by mail-wr1-f70.google.com with SMTP id r16so1299707wrm.18 for ; Thu, 24 Sep 2020 07:34:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=3HqrxwHoOSHrlwkdSsVQFFgcglebPJHiA/TqTJru7b8=; b=qA6pWyE0eItItPK+rZFpT0akxN+KqjgZioK8Kjdsr75hxjXuO4vbbw7dlOupoOaKHd mL+boudn26V1zNwUQu9DjQA6I7Gc90z0wFqTmDgxwXLebadUcBoMlkOPQhTBEgbFHRZZ iaUNLtQwYczTLBx3zlRN3IN7Vz5iVRm2OeSxydiMSdwPHkjYYs0kp+P8am+LUx07yVg+ mgLkJcsCEUFiB5JrNsnAVrmBIpN/m2r/HOeRI4RypyQqNU9hSyI5C4O72jqm8o0M1snU rI0R2QKl8OTUsRXEKnEDrGe624nrMfYfgCl6wWSe7TyBVbrE05ru8KAkH3q30UhtZ1T/ kF0w== X-Gm-Message-State: AOAM530H2dB1ejKXfjRw2I0h4Eewn7BaQ7ltHWB060tDCQL4h66rnHVT REbX9mJBWX4gLVV9t2qU+naZ+atLK2FzllOKTQTiWO3Hh4MkLfZuwvMBAU5BgNsCYejAKhj332f jUOgZK1iwd7PaKHY1 X-Received: by 2002:adf:e690:: with SMTP id r16mr63504wrm.15.1600958092878; Thu, 24 Sep 2020 07:34:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxov5wA5+uFn87KgQIxTqy6jBHTt3Q+u5yphyU1YoqfXrDp8sCS7h83YiRgzwvTLW4lQw/bGw== X-Received: by 2002:adf:e690:: with SMTP id r16mr63478wrm.15.1600958092640; Thu, 24 Sep 2020 07:34:52 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 9sm3644568wmf.7.2020.09.24.07.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 07:34:51 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 71B2E183A90; Thu, 24 Sep 2020 16:34:51 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , Jiri Olsa , Eelco Chaudron , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach In-Reply-To: <20200924001439.qitbu5tmzz55ck4z@ast-mbp.dhcp.thefacebook.com> References: <160079991372.8301.10648588027560707258.stgit@toke.dk> <160079991808.8301.6462172487971110332.stgit@toke.dk> <20200924001439.qitbu5tmzz55ck4z@ast-mbp.dhcp.thefacebook.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 24 Sep 2020 16:34:51 +0200 Message-ID: <874knn1bw4.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alexei Starovoitov writes: > On Tue, Sep 22, 2020 at 08:38:38PM +0200, Toke H=C3=83=C6=92=C3=82=C2=B8i= land-J=C3=83=C6=92=C3=82=C2=B8rgensen wrote: >> @@ -746,7 +748,9 @@ struct bpf_prog_aux { >> u32 max_rdonly_access; >> u32 max_rdwr_access; >> const struct bpf_ctx_arg_aux *ctx_arg_info; >> - struct bpf_prog *linked_prog; > > This change breaks bpf_preload and selftests test_bpffs. > There is really no excuse not to run the selftests. I did run the tests, and saw no more breakages after applying my patches than before. Which didn't catch this, because this is the current state of bpf-next selftests: # ./test_progs | grep FAIL test_lookup_update:FAIL:map1_leak inner_map1 leaked! #10/1 lookup_update:FAIL #10 btf_map_in_map:FAIL configure_stack:FAIL:BPF load failed; run with -vv for more info #72 sk_assign:FAIL test_test_bpffs:FAIL:bpffs test failed 255 #96 test_bpffs:FAIL Summary: 113/844 PASSED, 14 SKIPPED, 4 FAILED The test_bpffs failure happens because the umh is missing from the .config; and when I tried to fix this I ended up with: [..] CC [M] kernel/bpf/preload/bpf_preload_kern.o Auto-detecting system features: ... libelf: [ OFF ] ... zlib: [ OFF ] ... bpf: [ OFF ] No libelf found ...which I just put down to random breakage, turned off the umh and continued on my way (ignoring the failed test). Until you wrote this I did not suspect this would be something I needed to pay attention to. Now that you did mention it, I'll obviously go investigate some more, my point is just that in this instance it's not accurate to assume I just didn't run the tests... :) > I think I will just start marking patches as changes-requested when I see= that > they break tests without replying and without reviewing. > Please respect reviewer's time. That is completely fine if the tests are working in the first place. And even when they're not (like in this case), pointing it out is fine, and I'll obviously go investigate. But please at least reply to the email, not all of us watch patchwork regularly. (I'll fix all your other comments and respin; thanks!) -Toke