From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4F5C433DF for ; Mon, 10 Aug 2020 15:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AA0820772 for ; Mon, 10 Aug 2020 15:01:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CkzT/M9W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbgHJPBg (ORCPT ); Mon, 10 Aug 2020 11:01:36 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34993 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726528AbgHJPBf (ORCPT ); Mon, 10 Aug 2020 11:01:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597071694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h40qd2TnVpFmPFX/VP+5qYr4BYDGp0Yih60F15Jz+VQ=; b=CkzT/M9WKwz1I5Zbj1clDgr5WNVARn44CXYU3UD9gEuhEveXWr4auFmLjJFL0W3opAC7Z2 Zfp+moE5O3iTEYSGMtsCB40wfxi+KVhpljwW/ocIT1r5TgD4HKyEYvJVr4ihRjLQEcwKPz qhu8gJ8DJdUSHCp3KmRCu1C0Ed9FA4A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-Ceyuo8v2NLuU-DyBwUBoCA-1; Mon, 10 Aug 2020 11:01:31 -0400 X-MC-Unique: Ceyuo8v2NLuU-DyBwUBoCA-1 Received: by mail-wr1-f72.google.com with SMTP id 89so4324609wrr.15 for ; Mon, 10 Aug 2020 08:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=h40qd2TnVpFmPFX/VP+5qYr4BYDGp0Yih60F15Jz+VQ=; b=HGArDXd6+JKRse2tL8fDXVoqiUzN3aKw8POGXks9nlDhG0r1y1L1BbAt2HO9Flv2yn 5J2ahoaW7TPVoiS1x3LpDZ4SXpYc4gzKX+/huUjCwTmcKJplSUHdmN+x3/lAa1FmGhbZ lM3zKHpyXJ0JLqRd/BXEat3IR/GoiDcg2LD1hDvd+rGSjTv5wHkT+svHK3l3rpaAIjAt V20PFcIFxbEXlYSdAS1vRVY/w03dU5HdQbpfoqSJAVYNsXn0KIO3FnAeafxuk9JGvMOl hhkM3rXsrd+xtqZ1cSuEoOYCBmAFKsGozd6ml6evqazoifq3Vm54xF23/aTYuX2TNgkW bJBw== X-Gm-Message-State: AOAM533agzq8rg6tYC7zoCcb6lmH47fmQj8kWDPsvBh/stKCk0WFcxTM zb47gqLQ41tcdHuU3WQ1BLAsGL4/NhOBP2srW4OsUHb9Ag8N0pc2dZrtpimMKlit47lVu7dPyVL GKpa53pxFwkPLLlb6 X-Received: by 2002:a1c:f30f:: with SMTP id q15mr25438766wmq.60.1597071688821; Mon, 10 Aug 2020 08:01:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuS991p/0wGdAtnKqoZRDMvUuklyt9AENd/eOxL2ub0cmCDZZgXp1qhQhVd42WFaop1/PzBA== X-Received: by 2002:a1c:f30f:: with SMTP id q15mr25438749wmq.60.1597071688583; Mon, 10 Aug 2020 08:01:28 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id r22sm22597538wmh.45.2020.08.10.08.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 08:01:27 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7C32418282F; Mon, 10 Aug 2020 17:01:27 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com, Andrii Nakryiko Subject: Re: [PATCH bpf-next 0/5] BPF link force-detach support In-Reply-To: <20200729230520.693207-1-andriin@fb.com> References: <20200729230520.693207-1-andriin@fb.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 10 Aug 2020 17:01:27 +0200 Message-ID: <874kpa4kag.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Andrii Nakryiko writes: > This patch set adds new BPF link operation, LINK_DETACH, allowing process= es > with BPF link FD to force-detach it from respective BPF hook, similarly h= ow > BPF link is auto-detached when such BPF hook (e.g., cgroup, net_device, n= etns, > etc) is removed. This facility allows admin to forcefully undo BPF link > attachment, while process that created BPF link in the first place is left > intact. > > Once force-detached, BPF link stays valid in the kernel as long as there = is at > least one FD open against it. It goes into defunct state, just like > auto-detached BPF link. > > bpftool also got `link detach` command to allow triggering this in > non-programmatic fashion. I know this was already merged, but just wanted to add a belated 'thanks for adding this'! > Cc: Toke H=C3=B8iland-J=C3=B8rgensen BTW, I've noticed that you tend to drop Ccs on later versions of your patch series (had to go and lookup v2 of this to check that it was in fact merged). Is that intentional? :) -Toke