From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>, netdev@vger.kernel.org
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2-next] taprio: Add support for the SetAndHold and SetAndRelease commands
Date: Wed, 18 Dec 2019 15:05:13 -0800 [thread overview]
Message-ID: <874kxxck0m.fsf@linux.intel.com> (raw)
In-Reply-To: <060ba6e2de48763aec25df3ed87b64f86022f8b1.1576591746.git.Jose.Abreu@synopsys.com>
Hi Jose,
Jose Abreu <Jose.Abreu@synopsys.com> writes:
> Although this is already in kernel, currently the tool does not support
> them. We need these commands for full TSN features which are currently
> supported in Synopsys IPs such as QoS and XGMAC3.
>
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
This patch looks good in itself.
However, I feel that this is incomplete. At least the way I understand
things, without specifying which traffic classes are going to be
preemptible (or it's dual concept, express), I don't see how this is
going to be used in practice. Or does the hardware have a default
configuration, that all traffic classes are preemptible, for example.
What am I missing here?
Cheers,
--
Vinicius
next prev parent reply other threads:[~2019-12-18 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 14:10 [PATCH iproute2-next] taprio: Add support for the SetAndHold and SetAndRelease commands Jose Abreu
2019-12-17 21:25 ` Andre Guedes
2019-12-18 8:59 ` Jose Abreu
2019-12-18 23:05 ` Vinicius Costa Gomes [this message]
2019-12-18 23:08 ` Jose Abreu
2020-01-03 22:24 ` Murali Karicheri
2020-01-07 9:27 ` Jose Abreu
2020-01-17 22:18 ` Murali Karicheri
2020-01-20 9:18 ` Jose Abreu
2020-01-07 0:19 ` Andre Guedes
2020-01-07 9:29 ` Jose Abreu
2020-01-09 1:09 ` Andre Guedes
2019-12-31 4:30 ` David Ahern
2020-01-07 9:23 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kxxck0m.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).