From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0E9C43603 for ; Wed, 18 Dec 2019 23:04:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 611D72465E for ; Wed, 18 Dec 2019 23:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbfLRXEs (ORCPT ); Wed, 18 Dec 2019 18:04:48 -0500 Received: from mga01.intel.com ([192.55.52.88]:61556 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbfLRXEs (ORCPT ); Wed, 18 Dec 2019 18:04:48 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 15:04:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="417407896" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.26]) by fmsmga006.fm.intel.com with ESMTP; 18 Dec 2019 15:04:47 -0800 From: Vinicius Costa Gomes To: Jose Abreu , netdev@vger.kernel.org Cc: Joao Pinto , Jose Abreu , David Ahern Subject: Re: [PATCH iproute2-next] taprio: Add support for the SetAndHold and SetAndRelease commands In-Reply-To: <060ba6e2de48763aec25df3ed87b64f86022f8b1.1576591746.git.Jose.Abreu@synopsys.com> References: <060ba6e2de48763aec25df3ed87b64f86022f8b1.1576591746.git.Jose.Abreu@synopsys.com> Date: Wed, 18 Dec 2019 15:05:13 -0800 Message-ID: <874kxxck0m.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jose, Jose Abreu writes: > Although this is already in kernel, currently the tool does not support > them. We need these commands for full TSN features which are currently > supported in Synopsys IPs such as QoS and XGMAC3. > > Signed-off-by: Jose Abreu This patch looks good in itself. However, I feel that this is incomplete. At least the way I understand things, without specifying which traffic classes are going to be preemptible (or it's dual concept, express), I don't see how this is going to be used in practice. Or does the hardware have a default configuration, that all traffic classes are preemptible, for example. What am I missing here? Cheers, -- Vinicius