Re: [PATCH 10/18] rhashtable: remove rhashtable_walk_peek()

Herbert Xu
2018-06-02T15:48:51Z

On Fri, Jun 01, 2018 at 02:44:09PM +1000, NeilBrown wrote:
> This function has a somewhat confused behavior that is not properly
> described by the documentation.
> Sometimes is returns the previous object, sometimes it returns the
> next one.
> Sometimes it changes the iterator, sometimes it doesn't.
>
> This function is not currently used and is not worth keeping, so
> remove it.
>
> A future patch will introduce a new function with a
> simpler interface which can meet the same need that
> this was added for.
>
> Signed-off-by: NeilBrown <neilb@suse.com>

Please keep Tom Herbert in the loop. IIRC he had an issue with
this patch.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt