From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610 Date: Thu, 29 Mar 2018 10:15:25 +0300 Message-ID: <874lkzmjxu.fsf@kamboji.qca.qualcomm.com> References: <20180329065818.9338-1-rfried@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Cc: loic.poulain@linaro.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org To: Ramon Fried Return-path: In-Reply-To: <20180329065818.9338-1-rfried@codeaurora.org> (Ramon Fried's message of "Thu, 29 Mar 2018 09:58:18 +0300") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org (adding devicetree list) Ramon Fried writes: > wcn3610 can only operate on 2.4GHz band due to RF limitation. > If wcn36xx digital block is associated with an external IRIS > RF module, retrieve the id and disable 5GHz band in case of > wcn3610 id. > > Signed-off-by: Ramon Fried > --- > v2: fixed wrong assignment, which is logically introduces the > same behaviour, but for correctness. > > drivers/net/wireless/ath/wcn36xx/main.c | 4 +++- > drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c > index ab5be6d2c691..833531a68c95 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -1146,7 +1146,7 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) > BIT(NL80211_IFTYPE_MESH_POINT); > > wcn->hw->wiphy->bands[NL80211_BAND_2GHZ] = &wcn_band_2ghz; > - if (wcn->rf_id != RF_IRIS_WCN3620) > + if (wcn->rf_id != RF_IRIS_WCN3610 && wcn->rf_id != RF_IRIS_WCN3620) > wcn->hw->wiphy->bands[NL80211_BAND_5GHZ] = &wcn_band_5ghz; > > wcn->hw->wiphy->max_scan_ssids = WCN36XX_MAX_SCAN_SSIDS; > @@ -1248,6 +1248,8 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn, > if (iris_node) { > if (of_device_is_compatible(iris_node, "qcom,wcn3620")) > wcn->rf_id = RF_IRIS_WCN3620; > + else if (of_device_is_compatible(iris_node, "qcom,wcn3610")) > + wcn->rf_id = RF_IRIS_WCN3610; > of_node_put(iris_node); > } Should we document qcom,wcn3610 just like wcn3620 is: Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt: "qcom,wcn3620", -- Kalle Valo