From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com ([134.134.136.126]:7563 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbeBZTaw (ORCPT ); Mon, 26 Feb 2018 14:30:52 -0500 From: Vinicius Costa Gomes To: Florian Fainelli , intel-wired-lan@lists.osuosl.org Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org, jesus.sanchez-palencia@intel.com Subject: Re: [next-queue PATCH 5/8] igb: Add support for ethtool MAC address filters In-Reply-To: References: <20180224012036.5834-1-vinicius.gomes@intel.com> <20180224012036.5834-6-vinicius.gomes@intel.com> Date: Mon, 26 Feb 2018 11:30:51 -0800 Message-ID: <874lm3blas.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: Hi, Florian Fainelli writes: > On February 23, 2018 5:20:33 PM PST, Vinicius Costa Gomes wrote: >>This adds the capability of configuring the queue steering of arriving >>packets based on their source and destination MAC addresses. >> >>In practical terms this adds support for the following use cases, >>characterized by these examples: >> >>$ ethtool -N eth0 flow-type ether dst aa:aa:aa:aa:aa:aa action 0 >>(this will direct packets with destination address "aa:aa:aa:aa:aa:aa" >>to the RX queue 0) >> >>$ ethtool -N eth0 flow-type ether src 44:44:44:44:44:44 action 3 >>(this will direct packets with destination address "44:44:44:44:44:44" >>to the RX queue 3) >> >>Signed-off-by: Vinicius Costa Gomes >>--- > > [snip] > >>diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c >>b/drivers/net/ethernet/intel/igb/igb_ethtool.c >>index 143f0bb34e4d..d8686a0f5b5d 100644 >>--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c >>+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c >>@@ -152,6 +152,9 @@ static const char >>igb_priv_flags_strings[][ETH_GSTRING_LEN] = { >> >> #define IGB_PRIV_FLAGS_STR_LEN ARRAY_SIZE(igb_priv_flags_strings) >> >>+static const u8 broadcast_addr[ETH_ALEN] = { >>+ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; > > This is already defined in an existing header, don't have it handy but > likely etherdevice.h. Yeah, I didn't find the address definition, but there's a helper to build a broadcast address, which is just what I need. Thanks. > > -- > Florian Cheers, -- Vinicius