From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: [PATCH net-next 1/6] tcp_metrics: panic when tcp_metrics can not be allocated Date: Mon, 09 Mar 2015 13:27:10 -0500 Message-ID: <874mpu10xt.fsf_-_@x220.int.ebiederm.org> References: <871tlxtbhd.fsf_-_@x220.int.ebiederm.org> <87d25hrv9m.fsf@x220.int.ebiederm.org> <20150219.144929.1003473344851168804.davem@davemloft.net> <87h9tu114z.fsf_-_@x220.int.ebiederm.org> Mime-Version: 1.0 Content-Type: text/plain Cc: edumazet@google.com, netdev@vger.kernel.org, stephen@networkplumber.org, nicolas.dichtel@6wind.com, roopa@cumulusnetworks.com, hannes@stressinduktion.org, ddutt@cumulusnetworks.com, vipin@cumulusnetworks.com, shmulik.ladkani@gmail.com, dsahern@gmail.com To: David Miller Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:43822 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbbCISbB (ORCPT ); Mon, 9 Mar 2015 14:31:01 -0400 In-Reply-To: <87h9tu114z.fsf_-_@x220.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 09 Mar 2015 13:22:52 -0500") Sender: netdev-owner@vger.kernel.org List-ID: Panic so that in the unlikely event we have problems we will have a clear place to start debugging instead of a mysterious NULL pointer deference later on. Signed-off-by: "Eric W. Biederman" --- net/ipv4/tcp_metrics.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c index e5f41bd5ec1b..fdf4bdda971f 100644 --- a/net/ipv4/tcp_metrics.c +++ b/net/ipv4/tcp_metrics.c @@ -1186,5 +1186,6 @@ cleanup_subsys: unregister_pernet_subsys(&tcp_net_metrics_ops); cleanup: + panic("Could not allocate the tcp_metrics hash table\n"); return; } -- 2.2.1