From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.171.202.116 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795121590; b=n+6/hOOfHJnJ1ppBoTCCZ6tyXOx81aLCIlttxstwToFht1SSbMRRQlpbQg9wbc1hdzaJ FeDfBBxWuwM/3YYRtEAIUJXxvsl5heXDQm8AK5viid7yN5pY0vM9YfsAWDsPu87I4Q5it hMK3+WYgnDoOHK2IZtrbOZ2ibtjnb/X/fzGkBfuA5/DpQ7B2cyjvgVWtR/tmi+4WRpH3+ sZu3GyOxEzvUXqRRxEu0aUSpIBC+Sek4VNQPNpYyAoJLxE3GQJRPAGlfudzzEmV+gzuDv ptyrnKCBL4kq/Jo2NJilcw/NE+2BX5kwuyoNlv0Ze2z3jJIkfg6V5QoxS5QXe7OsBbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795121590; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:In-Reply-To:References:User-Agent:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding: X-Last-TLS-Session-Version; bh=bhQV5Yxj7EHBlSO67J3AjWtG+BkdwCTCOMv6otj2Ow0=; b=ZeQfJR0khxxf0whKWf53D+TXbNuO5ERuI9Zw7qSAsjpIDbp9E5tFQBkMWTprhZ+Qbzz8 X/0VqiV7K1+VnbEolzhP+abptO6j62mXsepa265sV/EklqHPUA9M4RCZD8bc1BeJddEKv hNw2b3yydYoE8Zv1DUZDD0FBdtYkBhfMGAswmocZDiNvgN3Tiz4bSwwApl9JXroeyiX9O vfySy2BdMShokdF51g0tMMAd5ikq6A9Buvoh+i49t2cnDpEDCCDFmiYnXfcyezQbHNQsV Th4BUCscCdbcH0hWTVcAKsSIlVrltAdysaO1bE4zGfLu/wrfeBi7yE6HamJk/4V+Y4w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=yWovXsCL; arc=none smtp.remote-ip=185.171.202.116 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4299606A337 for ; Thu, 19 Nov 2026 20:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C4299606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=yWovXsCL Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 1E7C2C2F4C7; Thu, 19 Nov 2026 20:53:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 894626035B; Thu, 19 Nov 2026 20:53:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3507411BC0E78; Thu, 19 Nov 2026 21:52:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795121581; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=bhQV5Yxj7EHBlSO67J3AjWtG+BkdwCTCOMv6otj2Ow0=; b=yWovXsCLMroYPdQQehh0R52sZplMpO3lhiFSbOiM1K/uIjSvuxCqxC0IOjO31Qu9h1EpEF CHQfBFtZKOSMqFfP5v0U+9QE3LKYgY7cZTSx3mydjnxeo3y9j5sAr9usrnVf+0dJ/m4FqZ OOMfi4qXo33VwF9sVtULZClWd5fPiHGr/XSrT77GbbqG07MlBylWqzRqtEcKgFGN7zxMW4 AqI4OcEJlcOQd1HQyZWmRfgO+pbDqla1q/HPwGYF6tzQ5slrJ4fY/SBrfeyB/ef0ueG4Xd OIAW9/qHNpv18oPKscFMkyUt/diPgrDB4TkjHTUL4wr4vOksk04FNFzBE9bBhw== From: Miquel Raynal To: Andrey Misiurov Cc: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ieee802154: keep the original error after a netns rollback In-Reply-To: <20261119172413.2068073-1-amisiurov@cloudlinux.com> (Andrey Misiurov's message of "Thu, 19 Nov 2026 18:24:13 +0100") References: <20261119172413.2068073-1-amisiurov@cloudlinux.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Thu, 19 Nov 2026 21:52:57 +0100 Message-ID: <875wxsczme.fsf@bootlin.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Andrey, > +++ b/net/ieee802154/core.c > @@ -222,6 +222,7 @@ > { > struct wpan_dev *wpan_dev; > int err =3D 0; > + int ret; >=20=20 > list_for_each_entry(wpan_dev, &rdev->wpan_dev_list, list) { > if (!wpan_dev->netdev) > @@ -249,6 +250,7 @@ > return 0; >=20=20 > errout: > + ret =3D err; > /* failed -- clean up to old netns */ > net =3D wpan_phy_net(&rdev->wpan_phy); >=20=20 > @@ -264,7 +266,7 @@ > wpan_dev->netdev->netns_immutable =3D true; Shall we just shadow int err in this loop? the current implementation is correct but is a bit strange (having ret and err next to each other). > } >=20=20 > - return err; > + return ret; > } >=20=20 > void cfg802154_dev_free(struct cfg802154_registered_device *rdev) Thanks, Miqu=C3=A8l