From: Thomas Gleixner <tglx@linutronix.de>
To: Sagi Maimon <maimon.sagi@gmail.com>
Cc: richardcochran@gmail.com, luto@kernel.org, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, arnd@arndb.de, geert@linux-m68k.org,
peterz@infradead.org, hannes@cmpxchg.org, sohil.mehta@intel.com,
rick.p.edgecombe@intel.com, nphamcs@gmail.com, palmer@sifive.com,
keescook@chromium.org, legion@kernel.org, mark.rutland@arm.com,
mszeredi@redhat.com, casey@schaufler-ca.com, reibax@gmail.com,
davem@davemloft.net, brauner@kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-arch@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v7] posix-timers: add clock_compare system call
Date: Sat, 23 Mar 2024 01:42:03 +0100 [thread overview]
Message-ID: <875xxdhj8k.ffs@tglx> (raw)
In-Reply-To: <878r29hjds.ffs@tglx>
On Sat, Mar 23 2024 at 01:38, Thomas Gleixner wrote:
> PTP_SYS_OFFSET_EXTENDED moves the outer sample points as close as
> possible to the actual PCH read and provides both outer samples to user
> space for analysis. It was introduced for a reason, no?
That said, it's a sad state of affairs that 16 drivers which did exist
before the introduction of the gettimex64() callback have not been
converted over to it within 4.5 years.
What's even worse is that 14 drivers have been merged _after_ the
gettimex64() callback got introduced without implementing it:
2019-02-12 drivers/net/ethernet/freescale/enetc/enetc_ptp.c
2019-10-24 drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
2019-11-15 drivers/net/dsa/ocelot/felix_vsc9959.c
2020-01-12 drivers/net/ethernet/xscale/ptp_ixp46x.c
2020-06-20 drivers/net/ethernet/mscc/ocelot_vsc7514.c
2020-06-24 drivers/net/phy/mscc/mscc_ptp.c
2020-08-24 drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
2020-11-05 drivers/net/dsa/hirschmann/hellcreek_ptp.c
2022-02-01 drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
2022-03-04 drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
2022-05-10 drivers/net/ethernet/sfc/siena/ptp.c
2022-11-02 drivers/net/ethernet/renesas/rcar_gen4_ptp.c
2023-01-13 drivers/net/dsa/microchip/ksz_ptp.c
2023-03-22 drivers/net/wireless/intel/iwlwifi/mvm/ptp.c
Not Sagi's fault at all, but it's telling and coherent with the approach
to solve the problem at hand.
See the previous reply for the observation on the letters P and C in PTP.
Oh well,
tglx
next prev parent reply other threads:[~2024-03-23 0:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 9:05 [PATCH v7] posix-timers: add clock_compare system call Sagi Maimon
2024-03-14 11:12 ` Thomas Gleixner
2024-03-14 12:19 ` Sagi Maimon
2024-03-14 15:59 ` Mark Rutland
2024-03-14 18:08 ` Thomas Gleixner
2024-03-20 14:42 ` Sagi Maimon
2024-03-23 0:38 ` Thomas Gleixner
2024-03-23 0:42 ` Thomas Gleixner [this message]
2024-03-24 11:04 ` Kurt Kanzenbach
2024-03-28 15:40 ` Sagi Maimon
2024-04-01 20:46 ` Thomas Gleixner
2024-04-02 5:42 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-02 9:24 ` Thomas Gleixner
2024-04-02 21:16 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-02 22:37 ` Thomas Gleixner
2024-04-02 23:37 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-03 13:48 ` Thomas Gleixner
2024-04-03 15:42 ` Thomas Gleixner
2024-04-11 2:55 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-11 7:11 ` Sagi Maimon
2024-04-11 16:33 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-14 12:22 ` Sagi Maimon
2024-04-15 17:23 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-16 8:39 ` Sagi Maimon
2024-03-14 15:46 ` Sagi Maimon
2024-03-14 18:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xxdhj8k.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=legion@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maimon.sagi@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mszeredi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nphamcs@gmail.com \
--cc=palmer@sifive.com \
--cc=peterz@infradead.org \
--cc=reibax@gmail.com \
--cc=richardcochran@gmail.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sohil.mehta@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).