From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F8E5CA1 for ; Thu, 22 Jun 2023 10:57:02 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DB551BE5 for ; Thu, 22 Jun 2023 03:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687431395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mtEvNEEfEgE6y0Va09/K93RbhGC9WjVk1y92ey2SXIQ=; b=W5eJyI+mWrXx2msmqElS8j/biYCHvY5XNep6DHuhwuVPzazfpHSryY2/0NKPLKTbp3Xc5Q 8uQOcQkeCzRDKKQEOcgSRGg2D/Bv7G5zItr1B3gbpqbQFm5tf5DpkNW17YXlEfgCElysPE vY2gtqObE5CPqISLpj6gdl1ZdnVJYYE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-YKH_Nn-pPuyo39iyMAWZ7Q-1; Thu, 22 Jun 2023 06:56:34 -0400 X-MC-Unique: YKH_Nn-pPuyo39iyMAWZ7Q-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3129750e403so350274f8f.3 for ; Thu, 22 Jun 2023 03:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687431393; x=1690023393; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mtEvNEEfEgE6y0Va09/K93RbhGC9WjVk1y92ey2SXIQ=; b=lZOlsRqsng4jtostNmEefJ7Hw2eqna7V068/QbwLpONQzYCVzlpD4YImN96r1WSxxG E443oo4u7Y+4hTsw+wPOHXiuU7Xgo74slkzv0DI6vzVLxXUqFbKY9zR64GwoS1kT2VrX gpiLLtJXJuVzYcACVD88lZYccBslT4mkKJMg6bd3dC62SZ+zVSjXhQDwsatGMrKdh2A8 Oe7L+CHJ4/QVciM04JrbSNGw4tCmFdJFgZ3rR2IXxwRdHWYP18uX5yxf18rNZpIny6FA 9fjYQR1TQeMdgWmbVoG3/9DXqLVwVWn2k7YVI9G4FSB7BdnaKwNkGyOc5sD5t9HJ46aI 5tnQ== X-Gm-Message-State: AC+VfDwbO1DpXny4nWW4mbIqMfbMTkJzGk7Pww6PGiRAPTcFSMQ+H21s g5COVEmMVq3TExAVQCcPy9yhR1OSEYLk1j8kgOFwo1wde5oP1hHAsz969gAbzTU3YgnQb8dL1HS YwZnzjAJl1j7Vv2+x X-Received: by 2002:a5d:480c:0:b0:30a:e5f1:eedd with SMTP id l12-20020a5d480c000000b0030ae5f1eeddmr14834298wrq.67.1687431392885; Thu, 22 Jun 2023 03:56:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7WSbvfGBCj5qQ17kuyaXgylgYoEA5grBw2s5jWMUBakMcarcNSS8Brg4cC/lzosHZN0RzjcA== X-Received: by 2002:a5d:480c:0:b0:30a:e5f1:eedd with SMTP id l12-20020a5d480c000000b0030ae5f1eeddmr14834283wrq.67.1687431392412; Thu, 22 Jun 2023 03:56:32 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id p7-20020a056000018700b003095bd71159sm6805634wrx.7.2023.06.22.03.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 03:56:31 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3DD89BBF45D; Thu, 22 Jun 2023 12:56:31 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Magnus Karlsson , Jakub Kicinski Cc: Maciej Fijalkowski , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, netdev@vger.kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, tirthendu.sarkar@intel.com, simon.horman@corigine.com Subject: Re: [PATCH v4 bpf-next 15/22] xsk: add multi-buffer documentation In-Reply-To: References: <20230615172606.349557-1-maciej.fijalkowski@intel.com> <20230615172606.349557-16-maciej.fijalkowski@intel.com> <87zg4uca21.fsf@toke.dk> <87o7l9c58j.fsf@toke.dk> <20230621133424.0294f2a3@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 22 Jun 2023 12:56:31 +0200 Message-ID: <875y7flq8w.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Magnus Karlsson writes: > On Wed, 21 Jun 2023 at 22:34, Jakub Kicinski wrote: >> >> On Wed, 21 Jun 2023 16:15:32 +0200 Magnus Karlsson wrote: >> > > Hmm, okay, that sounds pretty tedious :P >> > >> > Indeed if you had to do it manually ;-). Do not think this max is >> > important though, see next answer. >> >> Can't we add max segs to Lorenzo's XDP info? >> include/uapi/linux/netdev.h > > That should be straight forward. I am just reluctant to add a user > interface that might not be necessary. Yeah, that was why I was asking what the expectations were before suggesting adding this to the feature bits :) However, given that the answer seems to be "it varies"... > Maciej, how about changing your patch #13 so that we do not add a flag > for zc_mb supported or not, but instead we add a flag that gives the > user the max number of frags supported in zc mode? A 1 returned would > mean that max 1 frag is supported, i.e. mb is not supported. Any > number >1 would mean that mb is supported in zc mode for this device > and the returned number is the max number of frags supported. This way > we would not have to add one more user interface solely for getting > the max number of frags supported. What do you think? ...I think it's a good idea to add the field, and this sounds like a reasonable way of dealing with it (although it may need a bit more plumbing on the netlink side?) -Toke