From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67DFC433FE for ; Mon, 28 Mar 2022 16:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239143AbiC1Qoh (ORCPT ); Mon, 28 Mar 2022 12:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237488AbiC1Qoh (ORCPT ); Mon, 28 Mar 2022 12:44:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 611ED3FD9A for ; Mon, 28 Mar 2022 09:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648485774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fmjqOD3BHl74OkWJZQBaV4zUSFxZmdbs1YlkDjt8Mso=; b=K+308MT+uLX32h6w+uP8IuSZ1OgepCbcR/m7rgDouszd36EEo76DkrwUBe4Flz/g0nKIpE vAF714qMtH7mgVBPo1QqnI/1TUbY1mRQTEBjwL+fbyAP1s4SBCH76OyDWJY8CLUqyAb0uY QWEgm/J3+MtCNpTHstaf3buakKcT6Us= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-390-lrfyxwabO2G5aeLzX6CN_g-1; Mon, 28 Mar 2022 12:42:53 -0400 X-MC-Unique: lrfyxwabO2G5aeLzX6CN_g-1 Received: by mail-ej1-f71.google.com with SMTP id og28-20020a1709071ddc00b006dfb92d8e3fso7087571ejc.14 for ; Mon, 28 Mar 2022 09:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=fmjqOD3BHl74OkWJZQBaV4zUSFxZmdbs1YlkDjt8Mso=; b=4lwJx6SWVhgm1tpxN2fWCIO8pNKeh4WMMRqxPtvcObezu1DzqLshWEJqRmRL03+6VA duKC6zjxZYb7g2HfLUKHJOT2WxXzghtVVs2bo/WazdBXoSDX9fiYlz85lwOEmrzCDba1 7wnpU+Sukr1mpB/WN2JQfs3vzbLVOo6QE6mP8qRqJAyA7jD5a9dw0jM0EaqgWUBbBi9e wqLAwW3Jx4AC0CIJoMafxB3wTDa3lgHvEDohMsCUB1N+w06Xw6K71DZ2UZSprlNtN5Yf aBsorSywBYQq8I8FMkUOflluPiOgx7vwj4iUKRuByQKbaQva9xbMr77JeQn08ishqV2i lN1g== X-Gm-Message-State: AOAM530x/cs88O413CBP6VI8rWK0yJP2VxnA5a5bWGN4/CfYc4XIt2Nd a5VA6xf+/Y/o+pUm6xViyedOzGX03xVdQvN2XmP0nlPOpHNAtXgX2AFxz0q1j2FxA5dCya7Rg5G hXuItKULSQklkW5Qm X-Received: by 2002:a17:906:69d1:b0:6ce:7201:ec26 with SMTP id g17-20020a17090669d100b006ce7201ec26mr29008778ejs.105.1648485767655; Mon, 28 Mar 2022 09:42:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKl2T4YNWrX/G/bLyX2wwQvRxTA6uAkjsCaHLi/EPyI7kjYU0rENziBQoKf+YQfsM/0GREpQ== X-Received: by 2002:a17:906:69d1:b0:6ce:7201:ec26 with SMTP id g17-20020a17090669d100b006ce7201ec26mr29007877ejs.105.1648485757354; Mon, 28 Mar 2022 09:42:37 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id z5-20020a1709063a0500b006da8fa9526esm6164674eje.178.2022.03.28.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 09:42:36 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 224592279E0; Mon, 28 Mar 2022 18:42:36 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Christophe Leroy , "David S. Miller" , Jakub Kicinski , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Paolo Abeni Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "cake@lists.bufferbloat.net" Subject: Re: [PATCH net-next] sch_cake: Take into account guideline DEF/DGSIC/36 from French Administration In-Reply-To: <079a3b29-fec7-97c9-19d9-0bd9a17e63f1@csgroup.eu> References: <356a242a964fabbdf876a18c7640eb6ead6d0e6b.1648468695.git.christophe.leroy@csgroup.eu> <87bkxq5bgt.fsf@toke.dk> <079a3b29-fec7-97c9-19d9-0bd9a17e63f1@csgroup.eu> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 28 Mar 2022 18:42:36 +0200 Message-ID: <875yny58qr.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Christophe Leroy writes: > Le 28/03/2022 =C3=A0 17:43, Toke H=C3=B8iland-J=C3=B8rgensen a =C3=A9crit= =C2=A0: >> Christophe Leroy writes: >>=20 >>> French Administration has written a guideline that defines additional >>> DSCP values for use in its networks. >>=20 >> Huh, that's interesting! >>=20 >>> Add new CAKE diffserv tables to take those new values into account >>> and add CONFIG_NET_SCH_CAKE_DGSIC to select those tables instead of >>> the default ones. >>=20 >> ...however I don't think we should be including something this >> special-purpose into the qdisc kernel code, and certainly we shouldn't >> have a config option that changes the meaning of the existing diffserv >> keywords! > > By the way it doesn't really change meaning. Just enhances it indeed.=20 > Because they are not changing the meaning of existing DSCP codes, just=20 > adding new ones. Ah, OK, but then it's even easier, you can just add rules for the new values using the userspace options and let cake select the rest using the existing code. >> Rather, this is something that is best specified from userspace; and in >> fact Cake already has no less than two different ways to do this: the >> 'fwmark' option, and setting the skb->priority field. Have you tried >> using those? > > No I have not. In fact I'm just discovering the subject after some=20 > people told me "we are contractually required to apply this guideline,=20 > please make sure Linux kernel supports it". > > I'll give 'fwmark' and/or skb->priority a try. Is there any=20 > Documentation on that somewhere ? Both are documented in the tc-cake man page. -Toke