From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] bpf: do not WARN in bpf_warn_invalid_xdp_action()
Date: Mon, 15 Nov 2021 17:20:38 +0100 [thread overview]
Message-ID: <875ysto0fd.fsf@toke.dk> (raw)
In-Reply-To: <188c69a78ff2b1488ac16a1928311ea3ab39abed.1636987322.git.pabeni@redhat.com>
Paolo Abeni <pabeni@redhat.com> writes:
> The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by
> any bugged program, and even attaching a correct program to a NIC
> not supporting the given action.
>
> The resulting splat, beyond polluting the logs, fouls automated tools:
> e.g. a syzkaller reproducers using an XDP program returning an
> unsupported action will never pass validation.
>
> Replace the WARN_ONCE with a less intrusive pr_warn_once().
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2021-11-15 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 16:10 [RFC PATCH 0/2] bpf: do not WARN in bpf_warn_invalid_xdp_action() Paolo Abeni
2021-11-15 16:10 ` [RFC PATCH 1/2] " Paolo Abeni
2021-11-15 16:20 ` Toke Høiland-Jørgensen [this message]
2021-11-15 16:10 ` [RFC PATCH 2/2] bpf: let bpf_warn_invalid_xdp_action() report more info Paolo Abeni
2021-11-15 16:24 ` Toke Høiland-Jørgensen
2021-11-15 17:00 ` Paolo Abeni
2021-11-15 17:09 ` Toke Høiland-Jørgensen
2021-11-18 0:48 ` Alexei Starovoitov
2021-11-18 11:11 ` Paolo Abeni
2021-11-18 11:50 ` Toke Høiland-Jørgensen
2021-11-18 21:52 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ysto0fd.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).