From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F12FC4727F for ; Wed, 30 Sep 2020 08:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C4D72076E for ; Wed, 30 Sep 2020 08:06:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="obZJFpv+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728568AbgI3IG5 (ORCPT ); Wed, 30 Sep 2020 04:06:57 -0400 Received: from z5.mailgun.us ([104.130.96.5]:37200 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbgI3IG4 (ORCPT ); Wed, 30 Sep 2020 04:06:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601453216; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=4Lwa5DeeII1bp6aWK5KG1P3CtQ3ok00gYH2DlyVnRdY=; b=obZJFpv+8CHy0AwUKQOQkvM9FLHS9gbdaJcNJF1RcShWEzC7/GROciM3O8Fl1e/0uekf/dTT PGkmu1XMononv8FG1CswtTOw/JDAKV/bcDMKmelWI9tkyMme3Qg/JV6HfoM62O5szcnuyB3x higMpdtZvJlSqH1PlaBXtIg/QhQ= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5f743c620f8c6dd7d2e3c0cb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 30 Sep 2020 08:05:54 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9136BC433FE; Wed, 30 Sep 2020 08:05:54 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9B1FFC433C8; Wed, 30 Sep 2020 08:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9B1FFC433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Leon Romanovsky Cc: Srinivasan Raju , mostafa.afgani@purelifi.com, "David S. Miller" , Jakub Kicinski , Mauro Carvalho Chehab , Rob Herring , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices References: <20200924151910.21693-1-srini.raju@purelifi.com> <20200928102008.32568-1-srini.raju@purelifi.com> <20200930051602.GJ3094@unreal> Date: Wed, 30 Sep 2020 11:05:49 +0300 In-Reply-To: <20200930051602.GJ3094@unreal> (Leon Romanovsky's message of "Wed, 30 Sep 2020 08:16:02 +0300") Message-ID: <875z7velk2.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Leon Romanovsky writes: >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +config WLAN_VENDOR_PURELIFI >> + bool "pureLiFi devices" >> + default y > > "N" is preferred default. > >> + help >> + If you have a pureLiFi device, say Y. >> + >> + Note that the answer to this question doesn't directly affect the >> + kernel: saying N will just cause the configurator to skip all the >> + questions about these cards. If you say Y, you will be asked for >> + your specific card in the following questions. > > The text above makes no sense. Of course, it makes a lot of sense to > disable this device for whole world. This is a standard text for all vendor "groups", the actual driver should be selected in a separate config. This text has been copied from NET_VENDOR_ groups and used by all WLAN_VENDOR configs (or at least that was the original plan). -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches