From: Petr Machata <petrm@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Ido Schimmel <idosch@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net-next 2/2] net: sched: Do not pass root lock Qdisc_ops.enqueue
Date: Tue, 14 Jul 2020 18:19:39 +0200 [thread overview]
Message-ID: <875zaqjch0.fsf@mellanox.com> (raw)
In-Reply-To: <efa8d345-6457-3bcf-4fc3-f1e5e81f34a6@gmail.com>
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On 7/14/20 6:32 AM, Petr Machata wrote:
>> The reason for this was to make visible the dangerous possibility that
>> enqueue drops the lock. The previous patch undoes the lock dropping, and
>> therefore this patch can be reverted.
>>
>> Signed-off-by: Petr Machata <petrm@mellanox.com>
>
> Wow, I have not seen that this stuff actually went in net-next.
>
> Please make this a proper revert of
> aebe4426ccaa4838f36ea805cdf7d76503e65117 ("net: sched: Pass root lock to Qdisc_ops.enqueue")
>
> git revert aebe4426ccaa4838f36ea805cdf7d76503e65117
Sure.
prev parent reply other threads:[~2020-07-14 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 13:32 [PATCH net-next 0/2] net: sched: Do not drop root lock in tcf_qevent_handle() Petr Machata
2020-07-14 13:32 ` [PATCH net-next 1/2] " Petr Machata
2020-07-14 13:32 ` [PATCH net-next 2/2] net: sched: Do not pass root lock Qdisc_ops.enqueue Petr Machata
2020-07-14 14:24 ` Eric Dumazet
2020-07-14 16:19 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zaqjch0.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).