From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH wireless-drivers] mt76x0: Remove VLA usage Date: Wed, 08 Aug 2018 07:53:44 +0300 Message-ID: <87600l4fxj.fsf@kamboji.qca.qualcomm.com> References: <20180807225040.GA2164@beast> Mime-Version: 1.0 Content-Type: text/plain Cc: Stanislaw Gruszka , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Kees Cook Return-path: In-Reply-To: <20180807225040.GA2164@beast> (Kees Cook's message of "Tue, 7 Aug 2018 15:50:40 -0700") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kees Cook writes: > Even with "const" variables, the compiler will generate warnings about > VLA usage. In the quest to remove all VLAs from the kernel[1], this uses > a #define instead of a const to do the array sizing. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Fixes: e87b5039511a ("mt76x0: eeprom files") > Signed-off-by: Kees Cook > --- > Please include this for the v4.19 merge window. The VLA was introduced > with the new source file (which I also note is missing a SPDX line), so > I'd like to avoid the kernel ever getting released with a VLA here. Ok, I'll push this to v4.19. -- Kalle Valo