From: "Bjørn Mork" <bjorn@mork.no>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, khalidm <khalidm@cisco.com>,
David Singleton <davsingl@cisco.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume
Date: Mon, 06 Mar 2017 13:03:16 +0100 [thread overview]
Message-ID: <8760jmipdn.fsf@miraculix.mork.no> (raw)
In-Reply-To: <87bmten48r.fsf@miraculix.mork.no> ("Bjørn Mork"'s message of "Mon, 06 Mar 2017 10:28:36 +0100")
Bjørn Mork <bjorn@mork.no> writes:
> This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa
> ("e1000e: driver trying to free already-free irq"), which looks more
> than suspicious in this context. Haven't had time to test a revert
> yet. Just wanted to give an advance warning in case this isn't known.
Now tested. I can confirm that reverting commit 7e54d9d063fa ("e1000e:
driver trying to free already-free irq") fixes the issue.
Further testing also shows that "netif running" is irrelevant. The BUG
happens consistently on revery system resume, regardless of the e1000e
link state. Which sort of indicates that this change to the driver's
freeze callback wasn't tested with system suspend. Which seems.... odd?
Well, whatever. Please revert commit 7e54d9d063fa.
Bjørn
prev parent reply other threads:[~2017-03-06 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 9:28 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume Bjørn Mork
2017-03-06 12:03 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760jmipdn.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=aaron.f.brown@intel.com \
--cc=davsingl@cisco.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=khalidm@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).