From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Date: Wed, 25 Jan 2017 08:55:42 +0100 Message-ID: <8760l3375t.fsf@free-electrons.com> References: <20170125020249.GB24034@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jason Cooper , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Nadav Haklai , Wilson Ding , Kostya Porotchkin , Joe Zhou , Jon Pannell To: Andrew Lunn Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:49762 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbdAYH4F (ORCPT ); Wed, 25 Jan 2017 02:56:05 -0500 In-Reply-To: <20170125020249.GB24034@lunn.ch> (Andrew Lunn's message of "Wed, 25 Jan 2017 03:02:49 +0100") Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, On mer., janv. 25 2017, Andrew Lunn wrote: >> + [MV88E6341] = { >> + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, >> + .family = MV88E6XXX_FAMILY_6341, >> + .name = "Marvell 88E6341", >> + .num_databases = 4096, >> + .num_ports = 6, >> + .port_base_addr = 0x10, >> + .global1_addr = 0x1b, >> + .age_time_coeff = 15000, > > Hi Gregory > > Please could you check this timer in the datasheet. There is currently > a bug in the mv88e6390 support code. I also set it to 15s. But in fact > it is 3.75 seconds. The 6341 might also use 3.75 seconds. When I read your series I also thought about it and indeed it is 3.75 seconds. I will fix it. Thanks, Gregory > > Thanks > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com