From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, serge@hallyn.com
Subject: Re: [PATCH net-next] scm: Don't use struct ucred in NETLINK_CB and struct scm_cookie.
Date: Fri, 07 Sep 2012 14:25:09 -0700 [thread overview]
Message-ID: <87627ple4q.fsf@xmission.com> (raw)
In-Reply-To: <20120907.144151.1366430170552241987.davem@davemloft.net> (David Miller's message of "Fri, 07 Sep 2012 14:41:51 -0400 (EDT)")
David Miller <davem@davemloft.net> writes:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 07 Sep 2012 17:07:26 +0200
>
>> Seems fine to me, but I am not sure why you kept NETLINK_CREDS()
>> defined/used once.
>
> There are two remaining users, kernel/audit.c and scsi netlink.
Good point. I have a change to kernel/audit.c that removes the
usage. I believe the scsi netlink usage is just plain bogus,
and it wants the netlink port identifier instead.
Would anyone mind if we changed the name of the field in netlink from
pid to portid? It seems to cause a lot of confusion. We can't change
the user space fields of course but...
Right now because we can now use current using NETLINK_CREDS in the
kernel is unnecessary.
Eric
next prev parent reply other threads:[~2012-09-07 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 4:20 [PATCH net-next] scm: Don't use struct ucred in NETLINK_CB and struct scm_cookie Eric W. Biederman
2012-09-07 15:07 ` Eric Dumazet
2012-09-07 18:41 ` David Miller
2012-09-07 21:25 ` Eric W. Biederman [this message]
2012-09-07 21:32 ` David Miller
2012-09-07 18:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87627ple4q.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox