From: Dan Smith <danms@us.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: containers@lists.osdl.org, Alexey Dobriyan <adobriyan@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] c/r: Add AF_UNIX support (v7)
Date: Tue, 04 Aug 2009 15:47:34 -0700 [thread overview]
Message-ID: <8763d3dwmx.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <20090804223141.GA14254@us.ibm.com> (Serge E. Hallyn's message of "Tue\, 4 Aug 2009 17\:31\:41 -0500")
SH> why only free iov_base if ret!=0?
Because I was diagnosing a crash that only seemed to happen when I
free()'d the buffer after it was used by sendmsg() and I forgot to
remove this :(
>> + a->sk_peercred.pid = task_tgid_vnr(current);
>> + a->sk_peercred.uid = ctx->realcred->uid;
SH> I don't know how much it matters, but of course root could be
SH> restarting a set of tasks owned by several non-root uids, and the
SH> peercred.uid's might need to be something other than
ctx-> realcred->uid. Or not?
Oh, so you're suggesting I use ctx->ecred instead? I didn't actually
notice the double declaration in the ckpt_ctx, but I guess that would
be better.
--
Dan Smith
IBM Linux Technology Center
email: danms@us.ibm.com
next prev parent reply other threads:[~2009-08-04 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1249331463-11887-1-git-send-email-danms@us.ibm.com>
2009-08-03 20:31 ` [PATCH 3/5] Add common socket helpers to unify the security hooks Dan Smith
2009-08-04 19:20 ` Serge E. Hallyn
2009-08-04 19:43 ` Dan Smith
2009-08-04 19:58 ` Serge E. Hallyn
2009-08-03 20:31 ` [PATCH 5/5] c/r: Add AF_UNIX support (v7) Dan Smith
2009-08-04 19:57 ` Serge E. Hallyn
2009-08-04 20:52 ` Serge E. Hallyn
2009-08-04 21:02 ` Dan Smith
2009-08-04 21:17 ` Serge E. Hallyn
2009-08-04 22:24 ` Dan Smith
2009-08-04 22:31 ` Serge E. Hallyn
2009-08-04 22:47 ` Dan Smith [this message]
2009-08-05 13:29 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763d3dwmx.fsf@caffeine.danplanet.com \
--to=danms@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=containers@lists.osdl.org \
--cc=netdev@vger.kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).