From: Kurt Kanzenbach <kurt@linutronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
magnus.karlsson@intel.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, bpf@vger.kernel.org,
sriram.yagnaraman@ericsson.com, richardcochran@gmail.com,
benjamin.steinke@woks-audio.com, bigeasy@linutronix.de,
Chandan Kumar Rout <chandanx.rout@intel.com>
Subject: Re: [PATCH net-next 3/4] igb: add AF_XDP zero-copy Rx support
Date: Wed, 14 Aug 2024 10:29:29 +0200 [thread overview]
Message-ID: <877ccjzevq.fsf@kurt.kurt.home> (raw)
In-Reply-To: <ZrdxPgcqLdzCXCAS@boxer>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
>> case XDP_REDIRECT:
>> err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
>
> We were introducing a ZC variant of handling XDP verdict due to a fact
> that mostly what happens is the redirect to user space. We observed a
> reasonable perf improvement from likely()fying XDP_REDIRECT case.
Indeed, I can observe an improvement too.
I've introduced igb_run_xdp_zc() which takes care of that
optimization. Also it takes a pointer to the (read once) xsk_pool to
address the other comment.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2024-08-14 8:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 18:35 [PATCH net-next 0/4][pull request] igb: Add support for AF_XDP zero-copy Tony Nguyen
2024-08-08 18:35 ` [PATCH net-next 1/4] igb: prepare for AF_XDP zero-copy support Tony Nguyen
2024-08-08 20:38 ` Maciej Fijalkowski
2024-08-09 13:05 ` Kurt Kanzenbach
2024-08-09 13:14 ` Fijalkowski, Maciej
2024-08-09 13:19 ` Kurt Kanzenbach
2024-08-08 18:35 ` [PATCH net-next 2/4] igb: Introduce XSK data structures and helpers Tony Nguyen
2024-08-10 13:35 ` Maciej Fijalkowski
2024-08-08 18:35 ` [PATCH net-next 3/4] igb: add AF_XDP zero-copy Rx support Tony Nguyen
2024-08-10 13:55 ` Maciej Fijalkowski
2024-08-10 14:12 ` Maciej Fijalkowski
2024-08-14 8:29 ` Kurt Kanzenbach [this message]
2024-08-14 8:55 ` Maciej Fijalkowski
2024-08-08 18:35 ` [PATCH net-next 4/4] igb: add AF_XDP zero-copy Tx support Tony Nguyen
2024-08-10 14:10 ` Maciej Fijalkowski
2024-08-14 8:36 ` Kurt Kanzenbach
2024-08-14 8:55 ` Maciej Fijalkowski
2024-08-14 9:12 ` Kurt Kanzenbach
2024-08-14 10:26 ` Maciej Fijalkowski
2024-08-14 12:51 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ccjzevq.fsf@kurt.kurt.home \
--to=kurt@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=benjamin.steinke@woks-audio.com \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=chandanx.rout@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sriram.yagnaraman@ericsson.com \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).