From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<petrm@nvidia.com>
Subject: Re: [PATCH net-next 1/2] nexthop: Fix out-of-bounds access during attribute validation
Date: Mon, 11 Mar 2024 16:52:23 +0100 [thread overview]
Message-ID: <877ci8lq9m.fsf@nvidia.com> (raw)
In-Reply-To: <20240311074702.340dafcf@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> On Sun, 10 Mar 2024 23:41:53 +0200 Ido Schimmel wrote:
>> > 'tb' on the stack only needs to be ARRAY_SIZE as well; that's the
>> > benefit of the approach - only declare what you need.
>>
>> The reasoning for that is explained in Petr's commit message:
>>
>> "
>> - To allow querying for presence of the attribute, have all the attribute
>> arrays sized to NHA_MAX, regardless of what is permitted by policy, and
>> pass the corresponding value to nlmsg_parse() as well.
>> "
>>
>> IOW, with resizing 'tb' to ARRAY_SIZE:
>>
>> rtm_del_nexthop
>> nh_valid_get_del_req
>> if (tb[NHA_OP_FLAGS]) -> BOOM
>
> v2 coming, right? Please repost as soon as possible. v1 crashes AFAICT
> because tb is not 0-initialized so tb[NHA_OP_FLAGS] reads garbage.
Ido will send v2 later today.
next prev parent reply other threads:[~2024-03-11 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 17:32 [PATCH net-next 0/2] nexthop: Fix two nexthop group statistics issues Ido Schimmel
2024-03-10 17:32 ` [PATCH net-next 1/2] nexthop: Fix out-of-bounds access during attribute validation Ido Schimmel
2024-03-10 17:54 ` David Ahern
2024-03-10 21:41 ` Ido Schimmel
2024-03-11 1:10 ` David Ahern
2024-03-11 10:27 ` Petr Machata
2024-03-11 14:47 ` Jakub Kicinski
2024-03-11 15:52 ` Petr Machata [this message]
2024-03-10 17:32 ` [PATCH net-next 2/2] nexthop: Fix splat with CONFIG_DEBUG_PREEMPT=y Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ci8lq9m.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).